Remove unnecessary IBM i variants of tests #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This actually seems to execute fine on IBM i PASE, at least.
I guess VALUES wasn't supported pre-v7
kadler
reviewed
May 21, 2021
| @@ -3,7 +3,6 @@ IBM-DB2: db2_num_fields() - select | |||
| --SKIPIF-- | |||
| <?php | |||
| require_once('skipif.inc'); | |||
| require_once('skipif3.inc'); | |||
There was a problem hiding this comment.
This change seems unrelated to all the other changes.
There was a problem hiding this comment.
Actually not - it makes the LUW version of this test run on i, since skipif3 handles if a test runs on i (PASE or Db2 Connect). It's incredibly obviously named, no?
I'm guessing like v5r4/6.1 didn't support VALUES...
There was a problem hiding this comment.
Gotcha. From the diff it looks like an outlier since all the other changes were deleting V6 variants of the tests.
There was a problem hiding this comment.
Yeah, anything that was TBD removed was prob me restoring the non-PASE version fo the test to work on all platforms...
kadler
approved these changes
May 21, 2021
|
I think I'll merge these; if there's more redundant tests, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tended to be identical or disabled a working test. For the latter, I suspect IBM i's SQL dialect compatibility caught up.