Skip to content

Remove unnecessary IBM i variants of tests #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions tests/skipif.PASE
Original file line number Diff line number Diff line change
@@ -1,21 +1,13 @@
<?php
$PASE_ALT_TEST = <<< SKIPPASE
test_V6_002_ConnDbUncatalogedConn.phpt
test_V6_023_ColumnPrivileges.phpt
test_V6_039_FetchRowIndexPosNested_02.phpt
test_V6_041_FetchArrayMany_01.phpt
test_V6_053_SetAutocommit_02.phpt
test_V6_060_Tables_01.phpt
test_V6_061_Tables_02.phpt
test_V6_062_Tables_03.phpt
test_V6_064_Tables_05.phpt
test_V6_065_FilterTableName.phpt
test_V6_066_TableObjects.phpt
test_V6_080_ConnWrongDbAlias.phpt
test_V6_090_ConnmsgWrongDbAlias.phpt
test_V6_091_ConnmsgWrongUser.phpt
test_V6_092_ConnmsgWrongPwd.phpt
test_V6_102_NumFieldsSelect_01.phpt
test_V6_10353_MemLeak.phpt
test_V6_10353.phpt
test_V6_10931_LcaseTableName.phpt
Expand All @@ -27,8 +19,6 @@ test_V6_160_FetchBoth.phpt
test_V6_161_FetchBothNestedSelects_01.phpt
test_V6_162_FetchBothNestedSelects_02.phpt
test_V6_180_StmtErrMsg.phpt
test_V6_191_ColumnsTable_02.phpt
test_V6_192_ColumnsTable_03.phpt
test_V6_194_RetrieveCLOBColScrollable.phpt
test_V6_195_InsertRetrieveXMLData_01.phpt
test_V6_196_InsertRetrieveXMLData_02.phpt
Expand All @@ -44,8 +34,6 @@ test_V6_310_ClientInfo.phpt
test_V6_320_EscapeString.phpt
test_V6_321_ResultFetchArraysLobsXMLTypes.phpt
test_V6_6792_FieldTypeRetStrDatetimeTimestamp.phpt
test_V6_9173_ProcedurePersistentConn.phpt
test_V6_bigint.phpt
test_V6_clob_special_char.phpt
test_V6_connect_deallocator.phpt
test_V6_execute_many.phpt
Expand Down
1 change: 0 additions & 1 deletion tests/test_102_NumFieldsSelect_01.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ IBM-DB2: db2_num_fields() - select
--SKIPIF--
<?php
require_once('skipif.inc');
require_once('skipif3.inc');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems unrelated to all the other changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually not - it makes the LUW version of this test run on i, since skipif3 handles if a test runs on i (PASE or Db2 Connect). It's incredibly obviously named, no?

I'm guessing like v5r4/6.1 didn't support VALUES...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. From the diff it looks like an outlier since all the other changes were deleting V6 variants of the tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, anything that was TBD removed was prob me restoring the non-PASE version fo the test to work on all platforms...

?>
--FILE--
<?php
Expand Down
12 changes: 0 additions & 12 deletions tests/test_V6_023_ColumnPrivileges.phpt

This file was deleted.

12 changes: 0 additions & 12 deletions tests/test_V6_053_SetAutocommit_02.phpt

This file was deleted.

57 changes: 0 additions & 57 deletions tests/test_V6_060_Tables_01.phpt

This file was deleted.

58 changes: 0 additions & 58 deletions tests/test_V6_061_Tables_02.phpt

This file was deleted.

60 changes: 0 additions & 60 deletions tests/test_V6_062_Tables_03.phpt

This file was deleted.

59 changes: 0 additions & 59 deletions tests/test_V6_064_Tables_05.phpt

This file was deleted.

54 changes: 0 additions & 54 deletions tests/test_V6_065_FilterTableName.phpt

This file was deleted.

12 changes: 0 additions & 12 deletions tests/test_V6_102_NumFieldsSelect_01.phpt

This file was deleted.

Loading