ext/intl IntlChar::enumCharNames changes the signature to void. #10904
Conversation
ext/intl/intl_data.h
Outdated
| @@ -61,6 +61,14 @@ typedef struct _intl_data { | |||
| RETURN_NULL(); \ | |||
| } | |||
|
|
|||
| /* Check status by error code, if error return directly */ | |||
| #define INTL_CHECK_STATUS_RETURN(err, msg) \ | |||
There was a problem hiding this comment.
I know that this is copy-pasted but these backslashes are aligned very bad. I think you should use spaces instead of tabs if you don't mind.
ext/intl/uchar/uchar.stub.php
Outdated
| @@ -3411,7 +3411,7 @@ public static function chr(int|string $codepoint): ?string {} | |||
| public static function digit(int|string $codepoint, int $base = 10): int|false|null {} | |||
|
|
|||
| /** @tentative-return-type */ | |||
| public static function enumCharNames(int|string $start, int|string $end, callable $callback, int $type = IntlChar::UNICODE_CHAR_NAME): ?bool {} // TODO return values just don't make sense | |||
| public static function enumCharNames(int|string $start, int|string $end, callable $callback, int $type = IntlChar::UNICODE_CHAR_NAME): void {} | |||
There was a problem hiding this comment.
the void return type suggests that there is no error condition, or the function emits exceptions in case of errors, however, this function has at least 4 error conditions and exceptions are not necessarily thrown. Previously, in case of an error, either null or false was returned. In case of success, it returned null (OMG). So I think the sensible solution would be to return false on failure, and true on success. What do you think about it?
There was a problem hiding this comment.
I agree. At least this wouldn't break an existing if (IntlChar::enumCharNames(...) === false) {} pattern.
devnexen
force-pushed
the
intl_enumcharnames_changes
branch
from
655631f to
fa7ce56
Compare
No description provided.