Fix unstable get_iterator pointer in shm on Windows #17034
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
force-pushed
the
unstable-hooked-prop-iter-ptr-on-windows
branch
from
074fe93 to
7cab979
Compare
|
Yeah, sure, will check this as soon as possible. |
iluuu1994
force-pushed
the
unstable-hooked-prop-iter-ptr-on-windows
branch
from
7cab979 to
e20914f
Compare
|
@cmb69 Thank you! |
cmb69
reviewed
Dec 3, 2024
iluuu1994
force-pushed
the
unstable-hooked-prop-iter-ptr-on-windows
branch
from
e20914f to
26a8a91
Compare
iluuu1994
force-pushed
the
unstable-hooked-prop-iter-ptr-on-windows
branch
from
26a8a91 to
6c7e28a
Compare
|
Thank you @iluuu1994! This looks good to me now, and I also agree that this fix is necessary for Windows; or like I would word it, for environments which allow re-attaching to OPcache SHM (currently only Windows, and always allowed there, but that might change in the future). |
|
@cmb69 Thank you very much for verifying! |
Makes the code more self-documenting, avoiding a comment in all places. Also makes testing easier on platforms that do not support shm reattachment.
We don't need to free inheritance_cache, since at this point we haven't gotten around to tracking any dependencies.
iluuu1994
force-pushed
the
unstable-hooked-prop-iter-ptr-on-windows
branch
from
0d36c0e to
a690e1a
Compare
|
@cmb69 Based on your comment, I have introduced a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cmb69 I discovered this issue when talking about something related with Arnaud. I have not verified it myself, and thus also have not verified the fix. I don't have a Windows setup, and I'm afraid it will cost me a lot of time. Would it be at all possible for you to test this? If not, no worries.