[RFC] Deprecate PHP's Short Open Tags in PHP 7.4 #3972

Girgias · 2019-03-21T22:21:30Z

Implementation of my RFC for deprecating PHP Short tags: https://wiki.php.net/rfc/deprecate_php_short_tags

First time making a PR so help/reviews are appreciated.

On my local machine, some tests fail but I suppose this is due to me using WSL and not a native Linux.

~~Also, I'm having trouble fixing two tests related to strip_tags:~~

~~ext/standard/tests/strings/strip_tags_variation5.phpt~~
~~ext/standard/tests/strings/strip_tags_variation9.phpt~~

~~And it seems I made some changes to the output which I only realized with the diff view (don't know if that's due to my IDE or being on WSL).~~
Fixed.

Probably gonna do a second PR for the removal in PHP 8.

Prasitt · 2019-03-22T08:02:13Z

#3972

Girgias · 2019-03-22T13:21:53Z

I think this should be ready for review.
However I'm having trouble compiling PHP on my local WSL machine with all extensions to check how it affects those, I can't seem to make the SQLite3 extension work.

php.ini-development

pmmaga · 2019-04-24T12:54:36Z

ext/standard/tests/strings/strip_tags_basic1.phpt

@@ -43,6 +43,7 @@ foreach($string_array as $string)
 echo "Done";
 ?>
 --EXPECT--
+Deprecated: Directive 'short_open_tag' is deprecated in Unknown on line 0


For most of these tests, that ini entry doesn't really make a difference. I'd suggest to remove it from those tests instead of adding the deprecation notice.

I left the deprecation notices in the tokenizer tests, should I remove those too?

I'd say it is safe to remove from token_get_all_variation15.phpt given that the test doesn't even use the short open tags. For 002.phpt you'd have to check if it actually influences the behavior of the tokenizer.

The diff for 002 is pretty large as the behavior is indeed changes as can be seen with my PR for the removal in PHP 8 #3975

c.f. https://github.com/php/php-src/pull/3975/files#diff-55fd96e8ffa1d4e3150d3eb9dbc52829

Makes sense. On that PR, it would probably be more useful for that test to switch from <? to <?php to maintain its usefulness. As it stands right now, 2/3 of the things being tested are lost.

Yeah, was probably thinking that changing the opening tag would be better than changing the whole output. Will do that when I touch on that PR again.

php.ini-development

ext/tokenizer/tests/token_get_all_variation15.phpt

…etting.

…aders.

…files

… INI setting from the engine default. Commented out short_open_tag INI setting.

nikic

LGTM technically. I'll wait with merging this until the internals discussion settles.

Girgias · 2019-04-24T18:33:14Z

LGTM technically. I'll wait with merging this until the internals discussion settles.

No problem, I mean if the default change is a concern I don't mind reverting that and only have the deprecation notice for PHP 7.4.

jrfnl · 2019-06-10T15:58:46Z

Just checking in: what's the status of this ?

Girgias · 2019-06-10T17:54:14Z

Just checking in: what's the status of this ?

Well, I'll need to have a look at it again to change the implementation to go away from this controversial implementation and maybe even need to push it through the RFC process again.
So status: ¯_(ツ)_/¯

jrfnl · 2019-06-10T19:10:48Z

Thanks @Girgias for getting back to me. Would it be safe to presume that the chances of this making it into 7.4 are getting slim ?

Girgias · 2019-06-10T19:24:14Z

Thanks @Girgias for getting back to me. Would it be safe to presume that the chances of this making it into 7.4 are getting slim ?

As is yes, will try to work on it tomorrow.

nikic · 2019-06-14T14:25:14Z

Thanks @Girgias for getting back to me. Would it be safe to presume that the chances of this making it into 7.4 are getting slim ?

We're still a few weeks away from feature freeze. I think that most likely this will land, with the updated implementation approach.

nikic · 2019-06-17T10:38:22Z

Closing in favor of #4263.

cyber0pog · 2021-11-01T21:16:53Z

Sorry, but this is trash, now i want to quit php

<?php foreach($msOrganization as $org): ?>
  <option value="<?php echo $org['id']?>"><?php echo $org['name']?><?php echo !empty($org['inn']) ? ' [' . $org['inn'] . ']' : ''?></option>
<?php endforeach; ?>

It was so simple and beautiful (!)

<? foreach($msOrganization as $org): ?>
  <option value="<?=$org['id']?>"><?=$org['name']?><?=!empty($org['inn']) ? ' [' . $org['inn'] . ']' : ''?></option>
<? endforeach; ?>

nikic · 2021-11-01T21:24:10Z

Locking this so more people don't embarrass themselves. This change never landed and wouldn't have affected <?= in any case.

petk added the RFC label Mar 21, 2019

Girgias changed the title ~~[WIP][RFC] Deprecate PHP Short tags in PHP 7.4~~ [RFC] Deprecate PHP Short tags in PHP 7.4 Mar 22, 2019

Girgias mentioned this pull request Mar 22, 2019

[RFC] Remove PHP's short open tags in PHP 8 #3975

Closed

Girgias changed the title ~~[RFC] Deprecate PHP Short tags in PHP 7.4~~ [RFC] Deprecate PHP's Short Open Tags in PHP 7.4 Mar 25, 2019

Girgias force-pushed the PHP-7.4 branch from 33fbd04 to f25c36b Compare April 13, 2019 02:35

nikic reviewed Apr 24, 2019

View reviewed changes

php.ini-development Outdated Show resolved Hide resolved

nikic reviewed Apr 24, 2019

View reviewed changes

php.ini-development Show resolved Hide resolved

pmmaga reviewed Apr 24, 2019

View reviewed changes

Girgias force-pushed the PHP-7.4 branch from f25c36b to 316c9cf Compare April 24, 2019 13:41

Girgias mentioned this pull request Apr 24, 2019

Remove html_errors from INI Quick Reference #4067

Closed

nikic reviewed Apr 24, 2019

View reviewed changes

php.ini-development Outdated Show resolved Hide resolved

nikic reviewed Apr 24, 2019

View reviewed changes

ext/tokenizer/tests/token_get_all_variation15.phpt Outdated Show resolved Hide resolved

Girgias and others added 11 commits April 24, 2019 20:02

Deprecate Short tags

3b4e64b

Add depracation notice in strip_tags tests which use short_tags ini s…

b4dbf87

…etting.

Changed default value of PHP short tags in Zend engine and Windows he…

b542aa3

…aders.

Add Depreciation notice to tokeniser tests which use short tag INI.

4335db9

Fix strip_tags tests.

e48bffc

Changed default value for short_tags in the About section of PHP INI …

e1e9e78

…files

Removed short_open_tag from section detailling different configurated…

472b3c6

… INI setting from the engine default. Commented out short_open_tag INI setting.

Remove short_open_tag INI setting definition in strip_tags tests.

b0cd3a9

Fix carriage return in tests (again)

6f2ea35

[skip ci] Add INI setting value

29de8f2

Remove short_open_tags INI declaration in test.

79a9776

Girgias force-pushed the PHP-7.4 branch from 61c9ad4 to 79a9776 Compare April 24, 2019 18:04

nikic approved these changes Apr 24, 2019

View reviewed changes

nikic added this to the PHP 7.4 milestone Jun 14, 2019

Girgias mentioned this pull request Jun 14, 2019

[RFC] Short Open Tag deprecation V2 #4263

Closed

nikic closed this Jun 17, 2019

Girgias deleted the PHP-7.4 branch June 17, 2019 13:26

This comment has been minimized.

Sign in to view

php locked as spam and limited conversation to collaborators Nov 1, 2021

[RFC] Deprecate PHP's Short Open Tags in PHP 7.4 #3972

[RFC] Deprecate PHP's Short Open Tags in PHP 7.4 #3972

Uh oh!

Conversation

Girgias commented Mar 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Prasitt commented Mar 22, 2019

Uh oh!

Girgias commented Mar 22, 2019

Uh oh!

Uh oh!

Uh oh!

pmmaga Apr 24, 2019

Choose a reason for hiding this comment

Uh oh!

Girgias Apr 24, 2019

Choose a reason for hiding this comment

Uh oh!

pmmaga Apr 24, 2019

Choose a reason for hiding this comment

Uh oh!

Girgias Apr 24, 2019

Choose a reason for hiding this comment

Uh oh!

pmmaga Apr 24, 2019

Choose a reason for hiding this comment

Uh oh!

Girgias Apr 24, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nikic left a comment

Choose a reason for hiding this comment

Uh oh!

Girgias commented Apr 24, 2019

Uh oh!

jrfnl commented Jun 10, 2019

Uh oh!

Girgias commented Jun 10, 2019

Uh oh!

jrfnl commented Jun 10, 2019

Uh oh!

Girgias commented Jun 10, 2019

Uh oh!

nikic commented Jun 14, 2019

Uh oh!

nikic commented Jun 17, 2019

Uh oh!

This comment has been minimized.

cyber0pog commented Nov 1, 2021

Uh oh!

nikic commented Nov 1, 2021

Uh oh!

Uh oh!

Girgias commented Mar 21, 2019 •

edited

Loading