Skip to content

[RFC] Remove PHP's short open tags in PHP 8 #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

[RFC] Remove PHP's short open tags in PHP 8 #3975

wants to merge 14 commits into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Mar 22, 2019

Second part for the Depreciation and removal of PHP Short tags RFC: https://wiki.php.net/rfc/deprecate_php_short_tags

Based on #3972

@Girgias Girgias changed the title [RFC] Remove PHP short tags in PHP 8 [WIP][RFC] Remove PHP short tags in PHP 8 Mar 22, 2019
@petk petk added the RFC label Mar 22, 2019
KalleZ
KalleZ suggested changes Mar 24, 2019
View reviewed changes
carusogabriel
carusogabriel reviewed Mar 25, 2019
View reviewed changes
Girgias
Girgias commented Mar 25, 2019
View reviewed changes
Copy link
Member Author

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it wouldn't be wiser to change the opening tag in the string instead of replacing the tokenization output by a 'failure' case.

@Girgias Girgias changed the title [WIP][RFC] Remove PHP short tags in PHP 8 [RFC] Remove PHP's short open tags in PHP 8 Mar 25, 2019
Girgias and others added 14 commits April 13, 2019 04:35
@Girgias Girgias force-pushed the PHP-8-remove-Short-Tags branch from 115f72d to 23a9457 Compare April 13, 2019 02:37
@Girgias Girgias mentioned this pull request Apr 24, 2019
Closed
@Girgias
Copy link
Member Author

Girgias commented Apr 24, 2019

@Girgias
Copy link
Member Author

Girgias commented Jul 3, 2019

Closing as this is not relevant anymore wrt. the new implementation.

@Girgias Girgias closed this Jul 3, 2019
@Girgias Girgias deleted the PHP-8-remove-Short-Tags branch July 3, 2019 10:09
@Goddard

This comment has been minimized.

Sign in to view
@KalleZ

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KalleZ KalleZ KalleZ requested changes

@carusogabriel carusogabriel carusogabriel left review comments

Assignees
No one assigned
Labels
RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Girgias @Goddard @KalleZ @carusogabriel @petk