Fix logging in shutdown function #4007
Conversation
|
@remicollet Just pushed alternative solution using a new pipe for flushing log stream. If you could create RMP from this one, that would be great! Thanks! |
|
@remicollet bump :) |
|
@krakjoe Per the bug report, looks like this was already tested and the fix didn't work right :( |
|
Missed that ... So, closing this now then ... thanks all ... |
|
Yeah working on a different fix. Will create a new PR once it's ready. |
|
Re-opening as I will actually re-use it for another fix (it's just easier for me...) |
bukka
force-pushed
the
fpm_log_in_shutdown_fn
branch
from
f6f37a7 to
ffad6a9
Compare
|
Just pushed another attempt to fix that bug! @remicollet please could you create another RPM when you have time? |
bukka
force-pushed
the
fpm_log_in_shutdown_fn
branch
from
ffad6a9 to
84c8444
Compare
bukka
force-pushed
the
fpm_log_in_shutdown_fn
branch
from
84c8444 to
8e34059
Compare
|
Looks like
|
bukka
force-pushed
the
fpm_log_in_shutdown_fn
branch
from
22447ed to
821c400
Compare
|
Just rebased and pushed a fix for the split fallback issue that I noticed before. It's getting close to finish - Sorry I know it's taking ages but my free time is a bit limited... |
|
Think this PR should hopefully fix that nl test but needs more testing. |
This is supposed to be addressed by GH-4007, but that seems stalled for now.
This reverts commit f6f37a7.
bukka
force-pushed
the
fpm_log_in_shutdown_fn
branch
from
821c400 to
916b3e9
Compare
|
Closing in favour of #5161 . |
This might be a fix for https://bugs.php.net/bug.php?id=77653 but needs a bit more testing. Creating PR so I can see what Travis thinks about it.
@remicollet If you could create your testing RPM from this so OP can verify in Fedora 29, that would be awesome!