bugs in fpm logging #4273
Closed
bugs in fpm logging #4273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be addressed once https://bugs.php.net/bug.php?id=77653 gets fixed. I'm trying to fix it in #4007 but it's still in testing. The XFAIL won't probably work as it's mostly good and IIRC XFAILS fails if it's good. If anything it should be SKIP (ideally just for Azure as it's ok on Travis) |
|
XFAIL warns on pass, and shows XFAIlL on fail, and so never fails, and I
prefer it for something that should/could be fixed. I think SKIP better
suited to a test that can never pass (for a particular platform, for
example).
So that it doesn't interfere with test suites for now I'll mark XFAIL and
if for whatever reason you don't update the test when you fix the bug, the
persistent warning will be our queue to remove XFAIL.
I realise I didn't communicate precisely this morning, bit think it's best
to go with XFAIL, do you agree, given how XFAIL behaves, and given its in
principle fixable and going to be fixed?
…On Sun, 16 Jun 2019, 21:22 Jakub Zelenka, ***@***.***> wrote:
This should be addressed once https://bugs.php.net/bug.php?id=77653 gets
fixed. I'm trying to fix in #4007
<#4007> but it's still in testing.
The XFAIL won't probably work as it's mostly good and IIRC XFAILS fails if
it's good. If anything it should be SKIP (ideally just for Azure as it's ok
on Travis)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4273?email_source=notifications&email_token=AARB52URS3PL2XMN72J3IY3P22HIHA5CNFSM4HYQPKF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXZTO6A#issuecomment-502478712>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARB52XPGU3ZETGK6TWL6G3P22HIHANCNFSM4HYQPKFQ>
.
|
|
yeah go for it. ;) |
|
Merged as 116d42d Thanks. |
php-pulls
pushed a commit
that referenced
this pull request
Jun 17, 2019
|
@krakjoe No that's not related. Might be something Azure env specific and timings in the test. Will try to take a look. |
|
Thanks for update
…On Mon, 17 Jun 2019, 19:20 Jakub Zelenka, ***@***.***> wrote:
@krakjoe <https://github.com/krakjoe> No that's not related. Might be
something Azure env specific and timings in the test. Will try to take a
look.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4273?email_source=notifications&email_token=AARB52R6N4U4QVD7UMPUIWLP27BV5A5CNFSM4HYQPKF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX33UGY#issuecomment-502774299>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARB52TE63SZWT3IG7RQDPLP27BV5ANCNFSM4HYQPKFQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bukka this sporadically causes CI to fail, is this solvable, and are you going to solve it, or shall I merge this XFAIL section ?