Update gen_stub to support #if around classes

[adoy]

I have a case where I only want to create a class on some conditions

#if LIBCURL_VERSION_NUM >= 0x073E00 /* Available since 7.62.0 */
/**
 * @strict-properties
 * @not-serializable
 */
final class CurlUrl
{
}
#endif

This change will add the appropriate conditions around the zend_function_entry and zend_class_entry

[kocsismate]

Can you please check if your changes work with sensitive parameters? The generateAttributeInitialization() function generates the zend_mark_function_parameter_as_sensitive() invocations which add the attribute to a parameter

[adoy]

@kocsismate Thanks for this comment. I moved the attribute initialisation of methods inside the class registration, so that now the register_x_symbols function only contains zend_mark_function_parameter_as_sensitive for functions and will not take all the class entries in parameters. Does it make sense to you ?

Also I noticed after regenerating the files that sometime we do use four spaces and sometime tab as indent. I did not change that yet and will do the change in a commit after this change to make this consistant.

[TimWolla]

I moved the attribute initialisation of methods inside the class registration, so that now the register_x_symbols function only contains zend_mark_function_parameter_as_sensitive for functions and will not take all the class entries in parameters. Does it make sense to you ?

As the author of #8352 this certainly makes sense to me, as it makes the API much more comfortable to use (provided that it still works correctly 😃).

[adoy]

@kocsismate FYI this is the future commit for which i'm going to need this feature Curl URL Api

[cmb69]

@kocsismate FYI this is the future commit for which i'm going to need this feature Curl URL Api

FWIW, that would implement https://bugs.php.net/77991.

[TimWolla]

provided that it still works correctly

#8352 is now merged. There's a test in ext/pdo that checks that the attribute works properly for class methods, so if that one passes it should be good.

[adoy]

I rebased on master and everything seems to work except for indentation. But since it's a separate issue I created an other PR #8765

[adoy]

@kocsismate I rebased on master and regenerated all the files. Everything seems to work well. What do you think about this change ?

[kocsismate]

rebased on master and regenerated all the files. Everything seems to work well. What do you think about this change ?

There is still issue with the optimizer func info. Please run gen_stub.php --generate-optimizer-info

[kocsismate]

Thank you for your work!

[adoy]

@kocsismate Yep I didn't fixed it on this branch but it's due to the fact that the branch was only rebased on the commit without generation on master. I rebased it and merged it ! Thanks for your review