Skip to content

Indent with TAB in .h files generated by gen_stub #8765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2022
Merged

Indent with TAB in .h files generated by gen_stub #8765

merged 1 commit into from
Jun 13, 2022

Conversation

adoy
Copy link
Member

@adoy adoy commented Jun 13, 2022

Right now gen_stub generates .h files with a mix of 4 spaces and tabs.

@adoy adoy requested a review from kocsismate June 13, 2022 12:45
@adoy adoy mentioned this pull request Jun 13, 2022
Merged
@mvorisek
Copy link
Contributor

please use 4 spaces

@adoy adoy force-pushed the gen_stub_tab_indent branch from 7981bcc to 6fd2b39 Compare June 13, 2022 12:56
@adoy adoy merged commit 6fd2b39 into php:master Jun 13, 2022
@adoy
Copy link
Member Author

adoy commented Jun 13, 2022

please use 4 spaces

@mvorisek
https://github.com/php/php-src/blob/master/CODING_STANDARDS.md#syntax-and-indentation

@adoy adoy deleted the gen_stub_tab_indent branch June 13, 2022 13:02
@adoy
Copy link
Member Author

adoy commented Jun 13, 2022

@iluuu1994 @kocsismate Yep sorry about that my mistake I thought -f was enough but I didn't know --generate-optimizer-info wasn't included :-) Maybe at some point it should be ?

@kocsismate
Copy link
Member

Maybe at some point it should be ?

I'm not sure. The optimizer info applies only to php-src itself, while the rest of the options applies to 3rd party extensions as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kocsismate kocsismate kocsismate approved these changes

Assignees
No one assigned
Labels
Category: Build System Category: Engine Extension: calendar Extension: com_dotnet Extension: date Extension: dom Extension: enchant Extension: exif Extension: fileinfo Extension: filter Extension: ftp Extension: gmp Extension: hash Extension: iconv Extension: imap Extension: json Extension: ldap Extension: libxml Extension: mysqli Extension: oci8 Extension: odbc Extension: openssl Extension: pdo (core) Extension: sodium Extension: standard Extension: zip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adoy @mvorisek @kocsismate @iluuu1994