Resolve binding key path crash #1784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@barabashd Thanks for diving into the problem and your work on a solution! Though the stack trace isn't super helpful, the crash you're encountering is that the row view computes for an element that no longer exists. This computation causes the array subscript to get called for an invalid index, so you get a "index out of range" fatal error. We're not quite sure why SwiftUI does this in this case, and we have considered it an Apple bug, but it's nice to see that there's a workaround by shuffling the domain around. I'm going to merge this as-is and will make a few changes in a followup PR that fix the CI issue and an animation issue the original subscript intended to work around. |
stephencelis
added a commit
that referenced
this pull request
Jan 3, 2023
Merged
stephencelis
added a commit
that referenced
this pull request
Jan 3, 2023
stephencelis
added a commit
that referenced
this pull request
Jan 6, 2023
stephencelis
added a commit
that referenced
this pull request
Jan 6, 2023
This reverts commit fbe6847.
stephencelis
added a commit
that referenced
this pull request
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
In a nutshell: binding works differently from @swiftui.State binding and could lead to a crash.