Skip to content

Simplify/fix #1784 #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 3, 2023
Merged

Simplify/fix #1784 #1785

merged 3 commits into from
Jan 3, 2023

Conversation

stephencelis
Copy link
Member

This PR works on top of #1784 and:

  • Reduces the number of moving parts
  • Restores implicit animations by directly producing the binding from the observable object
  • Strongly retains the store in the binding to avoid losing writes

@stephencelis
Simplify/fix #1784
9983bd0 
This PR works on top of #1784 and:

  * Reduces the number of moving parts
  * Restores implicit animations by directly producing the binding from
    the observable object
  * Strongly retains the store in the binding to avoid losing writes
@stephencelis stephencelis requested a review from mbrandonw January 3, 2023 17:38
@stephencelis
Copy link
Member Author

@barabashd Thanks again for the original fix!

@stephencelis stephencelis merged commit 626c35c into main Jan 3, 2023
@stephencelis stephencelis deleted the binding-fix-2 branch January 3, 2023 18:37
stephencelis added a commit that referenced this pull request Jan 6, 2023
@stephencelis
Revert "Simplify/fix #1784 (#1785)"
d490868 
This reverts commit 626c35c.
@mbrandonw mbrandonw mentioned this pull request Jan 6, 2023
Closed
stephencelis added a commit that referenced this pull request Jan 6, 2023
@stephencelis
Revert #1784: Resolve binding key path crash (#1799)
cbf8a45 
* Revert "Simplify/fix #1784 (#1785)"

This reverts commit 626c35c.

* Revert "resolve binding key path crash (#1784)"

This reverts commit fbe6847.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrandonw mbrandonw mbrandonw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephencelis @mbrandonw