Skip to content

update to PyO3 0.19.0 #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2023
Merged

update to PyO3 0.19.0 #658

merged 1 commit into from
Jun 3, 2023

Conversation

davidhewitt
Copy link
Contributor

Bumps version of PyO3 to 0.19.0, making the required fixups and adopting use of the new PyList::to_tuple method.

Are there any other features which you were waiting for from the new PyO3?

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2023

Codecov Report

Merging #658 (1f3dc4d) into main (0fe0936) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #658      +/-   ##
==========================================
- Coverage   93.89%   93.83%   -0.07%     
==========================================
  Files          99       99              
  Lines       13765    13756       -9     
  Branches       25       25              
==========================================
- Hits        12925    12908      -17     
- Misses        834      842       +8     
  Partials        6        6              
Impacted Files Coverage Δ
src/input/input_python.rs 98.31% <100.00%> (-0.05%) ⬇️
src/serializers/type_serializers/function.rs 96.14% <100.00%> (+0.27%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fe0936...1f3dc4d. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 3, 2023

CodSpeed Performance Report

Merging #658 davidhewitt:pyo3-0.19 (1f3dc4d) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 125 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@samuelcolvin samuelcolvin merged commit e7108e8 into pydantic:main Jun 3, 2023
@samuelcolvin
Copy link
Member

Thanks so much, nothing else I know of.

@samuelcolvin samuelcolvin mentioned this pull request Jun 3, 2023
@davidhewitt davidhewitt deleted the pyo3-0.19 branch June 3, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants