Skip to content

allow typing-extensions-4.7.0+ on pypy3.9+ #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Jul 1, 2023

Change Summary

Remove the PyPy-specific version restriction on typing-extensions when PyPy3.9 or newer is used. The bug cited
in 12073b8 is specific to PyPy3.7 and PyPy3.8.

Related issue number

(discussed in 12073b8#r120315009)

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @davidhewitt

Remove the PyPy-specific version restriction on typing-extensions when
PyPy3.9 or newer is used.  The bug cited
in 12073b8 is specific to PyPy3.7
and PyPy3.8.
@mgorny
Copy link
Contributor Author

mgorny commented Jul 1, 2023

please review

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #723 (decff72) into main (7da65c4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #723   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files          99       99           
  Lines       13911    13911           
  Branches       25       25           
=======================================
  Hits        13026    13026           
  Misses        879      879           
  Partials        6        6           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da65c4...decff72. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 1, 2023

CodSpeed Performance Report

Merging #723 will not alter performances

Comparing mgorny:typing-ext-pypy39 (decff72) with main (7da65c4)

Summary

✅ 125 untouched benchmarks

@dmontagu dmontagu merged commit 0d12efd into pydantic:main Jul 1, 2023
@mgorny mgorny deleted the typing-ext-pypy39 branch July 1, 2023 15:24
@mgorny
Copy link
Contributor Author

mgorny commented Jul 1, 2023

Thanks!

@AlexWaygood AlexWaygood mentioned this pull request Jul 2, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants