Simplify typing_extensions pin #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We fixed the PyPy issues in [typing_extensions 4.7.1](https://github.com/python/typing_extensions/releases/tag/4.7.1) by working around [the bug in PyPy-3.7 and PyPy-3.8](https://foss.heptapod.net/pypy/pypy/-/issues/3958). Loosening the pin here will give us the option of running pydantic's tests with typing_extensions's main branch on more PyPy versions in CI as part of our [third-party nightly workflow](https://github.com/python/typing_extensions/blob/main/.github/workflows/third_party.yml). Doing that should hopefully reduce the chance of breakages like this in the future :)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
=======================================
Coverage 93.63% 93.63%
=======================================
Files 99 99
Lines 13911 13911
Branches 25 25
=======================================
Hits 13026 13026
Misses 879 879
Partials 6 6 Continue to review full report in Codecov by Sentry.
|
adriangb
approved these changes
Jul 2, 2023
|
Thank you! |
CodSpeed Performance ReportMerging #728 will degrade performances by 10.66%Comparing Summary
Benchmarks breakdown
|
Thanks for the lightning-fast merge! :D |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
typing_extensions 4.7.0 didn't work on PyPy-3.7 and PyPy-3.8, which led you to (very reasonably!) add an upper bound to your typing_extensions dependency on PyPy. However, we've since fixed the PyPy issues in typing_extensions 4.7.1 by working around the bug in PyPy-3.7 and PyPy-3.8 that caused the breakage.
Since typing_extensions 4.7.1 should work fine on PyPy-3.7 and PyPy-3.8, it should be fine to get rid of the upper bound now.
Loosening the pin here will also give typing_extensions the option of running pydantic's tests with typing_extensions's main branch on more PyPy versions in CI as part of our third-party nightly workflow. Doing that should hopefully reduce the chance of breakages like this in the future :)
Related issue number
No issue number, but this is a followup to these PRs:
Checklist
pydantic-core(except for expected changes)