Skip to content

fix pypy tests on windows #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix pypy tests on windows #757

merged 1 commit into from
Jul 10, 2023

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Avoids the crash in windows pypy PGO builds.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@davidhewitt davidhewitt added the Full Build cause CI to do a full build label Jul 10, 2023
@davidhewitt davidhewitt force-pushed the dh/fix-windows-pypy-tests branch from 0c53091 to b94d5f1 Compare July 10, 2023 13:30
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 10, 2023

CodSpeed Performance Report

Merging #757 will degrade performances by 61.16%

Comparing dh/fix-windows-pypy-tests (9ec612c) with main (a27b34e)

Summary

❌ 2 regressions
✅ 124 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main dh/fix-windows-pypy-tests Change
test_definition_model_core 1.8 ms 4.7 ms -61.16%
test_field_function_validator 795.4 µs 1,833.3 µs -56.62%

@davidhewitt
Copy link
Contributor Author

Benchmark "regressions" are expected because I've made these recurse deeper (they now run all the way to our hard-coded recursion limit).

@davidhewitt davidhewitt force-pushed the dh/fix-windows-pypy-tests branch 2 times, most recently from 2f11ae4 to cc153f2 Compare July 10, 2023 13:49
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #757 (9ec612c) into main (0b31711) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
- Coverage   93.65%   93.64%   -0.01%     
==========================================
  Files          99       99              
  Lines       13938    13942       +4     
  Branches       25       25              
==========================================
+ Hits        13053    13056       +3     
- Misses        879      880       +1     
  Partials        6        6              
Impacted Files Coverage Δ
src/recursion_guard.rs 95.65% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b31711...9ec612c. Read the comment docs.

@davidhewitt davidhewitt force-pushed the dh/fix-windows-pypy-tests branch from cc153f2 to 0096118 Compare July 10, 2023 14:11
@davidhewitt davidhewitt force-pushed the dh/fix-windows-pypy-tests branch from 0096118 to 9ec612c Compare July 10, 2023 14:33
@davidhewitt davidhewitt merged commit dfbedbd into main Jul 10, 2023
@davidhewitt davidhewitt deleted the dh/fix-windows-pypy-tests branch July 10, 2023 14:49
adriangb pushed a commit that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Full Build cause CI to do a full build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants