Skip to content

Bump version to 3.1rc4 #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Jun 25, 2017
Merged

Bump version to 3.1rc4 #2223

merged 38 commits into from
Jun 25, 2017

Conversation

twiecki
Copy link
Member

@twiecki twiecki commented May 26, 2017

After merging this we should not merge any other PRs until 3.1 is out.

@twiecki twiecki added this to the 3.1 milestone May 26, 2017
@fonnesbeck
Copy link
Member

There's one more in docs/source/conf.py

@fonnesbeck
Copy link
Member

The CHANGELOG should also be updated.

@twiecki
Copy link
Member Author

twiecki commented May 26, 2017

Ah, we have release notes, should probably remove CHANGELOG.

@twiecki
Copy link
Member Author

twiecki commented May 26, 2017

conf.py is added.

@fonnesbeck
Copy link
Member

Are we happy with the release notes as they are? One easy way to get a run-down of changes is:

git log --oneline --no-merges v3.0..HEAD

Maybe scan through that and see if there are additions we want to highlight.

@junpenglao
Copy link
Member

I found a bug: #2225

@fonnesbeck
Copy link
Member

I will test it now too.

@ferrine ferrine mentioned this pull request May 27, 2017
4 tasks
@junpenglao
Copy link
Member

Is there anything left to be done for release?

@aloctavodia
Copy link
Member

Given that #2294 is a bug fix and not a new feature shouldn't be part of the 3.1 release?

@twiecki
Copy link
Member Author

twiecki commented Jun 12, 2017

Update RELEASE-NOTES if anything changed, otherwise we should go ahead.

@junpenglao
Copy link
Member

We should wait for the bug fix of #2298

@ferrine
Copy link
Member

ferrine commented Jun 12, 2017

That's done. Is anything else left?

@ferrine
Copy link
Member

ferrine commented Jun 12, 2017

We then again need experimental 3.2 branch for new features with regular rebase on master.

@junpenglao
Copy link
Member

Also remove the 3.1 branch and clean up some other branch.

@junpenglao
Copy link
Member

And also #2258 is still broken.

@ferrine
Copy link
Member

ferrine commented Jun 13, 2017

#2290 is broken too

@twiecki
Copy link
Member Author

twiecki commented Jun 21, 2017

@fonnesbeck I think we're ready.

@fonnesbeck
Copy link
Member

OK, will get it rolling today.

@fonnesbeck
Copy link
Member

Testing the notebooks now. Can we replace bayesian_neural_network_advi.ipynb with bayesian_neural_network_opvi-advi.ipynb? The former is using an outdated API for part of it, otherwise it is complete overlap.

@twiecki
Copy link
Member Author

twiecki commented Jun 23, 2017

@fonnesbeck Yes, change the NB.

RELEASE-NOTES.md Outdated
@@ -32,7 +32,7 @@

- [Added Stein-Variational Gradient Descent as well as Amortized SVGD (experimental).](https://github.com/pymc-devs/pymc3/pull/2183)

- [Added pm.generator() to easily specify mini-batches.](http://pymc-devs.github.io/pymc3/notebooks/bayesian_neural_network_opvi-advi.html#Minibatch-ADVI)
- [Added `Minibatch` to easily specify mini-batches.](http://pymc-devs.github.io/pymc3/notebooks/bayesian_neural_network_opvi-advi.html#Minibatch-ADVI)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not used in this notebook... I think reference to VI intro is more suitable

@twiecki
Copy link
Member Author

twiecki commented Jun 24, 2017

I rebased this branch against master, make sure to force pull.

@twiecki
Copy link
Member Author

twiecki commented Jun 24, 2017

I wonder if we should just go to 3.1 immediately. We've been testing this a lot and had several successful RCs already.

@fonnesbeck
Copy link
Member

Yes, I was just going to use this RC to ensure that it installs and tests pass, after which I will immediately tag 3.1.

@fonnesbeck
Copy link
Member

Will do it in a separate PR.

@junpenglao
Copy link
Member

What about the new docs http://docs.pymc.io/ ?

@twiecki
Copy link
Member Author

twiecki commented Jun 25, 2017

@junpenglao It's functional but all the links still go the old site, so we would need to figure out a redirect before. I think we better leave that for the next release.

@junpenglao
Copy link
Member

@twiecki Cool. So I guess we are ready?

@twiecki twiecki merged commit 7d55010 into master Jun 25, 2017
@fonnesbeck
Copy link
Member

OK, will get the official 3.1 going then.

@twiecki
Copy link
Member Author

twiecki commented Jun 25, 2017

@fonnesbeck trying to upload 3.1rc4 to pypi but airport wifi is not cooperating. Let's do that, everyone install on a clean base and run tests and then go for 3.1.

@twiecki
Copy link
Member Author

twiecki commented Jun 25, 2017 via email

@fonnesbeck
Copy link
Member

Just pushed a 3.1 PR.

@junpenglao junpenglao deleted the bump_v3.1rc4 branch June 25, 2017 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants