-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Bump version to 3.1rc4 #2223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 3.1rc4 #2223
Conversation
There's one more in |
The CHANGELOG should also be updated. |
Ah, we have release notes, should probably remove CHANGELOG. |
conf.py is added. |
Are we happy with the release notes as they are? One easy way to get a run-down of changes is:
Maybe scan through that and see if there are additions we want to highlight. |
I found a bug: #2225 |
I will test it now too. |
Is there anything left to be done for release? |
Given that #2294 is a bug fix and not a new feature shouldn't be part of the 3.1 release? |
Update RELEASE-NOTES if anything changed, otherwise we should go ahead. |
We should wait for the bug fix of #2298 |
That's done. Is anything else left? |
We then again need experimental 3.2 branch for new features with regular rebase on master. |
Also remove the 3.1 branch and clean up some other branch. |
And also #2258 is still broken. |
#2290 is broken too |
@fonnesbeck I think we're ready. |
OK, will get it rolling today. |
Testing the notebooks now. Can we replace |
@fonnesbeck Yes, change the NB. |
…or minibatch processing
RELEASE-NOTES.md
Outdated
@@ -32,7 +32,7 @@ | |||
|
|||
- [Added Stein-Variational Gradient Descent as well as Amortized SVGD (experimental).](https://github.com/pymc-devs/pymc3/pull/2183) | |||
|
|||
- [Added pm.generator() to easily specify mini-batches.](http://pymc-devs.github.io/pymc3/notebooks/bayesian_neural_network_opvi-advi.html#Minibatch-ADVI) | |||
- [Added `Minibatch` to easily specify mini-batches.](http://pymc-devs.github.io/pymc3/notebooks/bayesian_neural_network_opvi-advi.html#Minibatch-ADVI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not used in this notebook... I think reference to VI intro is more suitable
I rebased this branch against master, make sure to force pull. |
I wonder if we should just go to 3.1 immediately. We've been testing this a lot and had several successful RCs already. |
Yes, I was just going to use this RC to ensure that it installs and tests pass, after which I will immediately tag 3.1. |
Will do it in a separate PR. |
What about the new docs http://docs.pymc.io/ ? |
@junpenglao It's functional but all the links still go the old site, so we would need to figure out a redirect before. I think we better leave that for the next release. |
@twiecki Cool. So I guess we are ready? |
OK, will get the official 3.1 going then. |
@fonnesbeck trying to upload 3.1rc4 to pypi but airport wifi is not cooperating. Let's do that, everyone install on a clean base and run tests and then go for 3.1. |
I think so! @fonnesbeck?
…On Jun 25, 2017 3:39 PM, "Junpeng Lao" ***@***.***> wrote:
@twiecki <https://github.com/twiecki> Cool. So I guess we are ready?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2223 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AApJmCGjIFoqYfWESlZie-KlfY7JhdKeks5sHmMigaJpZM4Nnf7C>
.
|
Just pushed a 3.1 PR. |
After merging this we should not merge any other PRs until 3.1 is out.