Plot posterior reliable mode calculation for continuous variables and ignore kde_plot=True for discretes ones #2294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloctavodia
changed the title
|
The checks for this PR (as well as other) are failing because |
|
Yeah Travis is suddenly hitting the maximum time limit a lot lately, and it is a bit random sometimes. |
|
Indeed is a bit random. Before writing my previous comment I restarted (twice) 4 timeout jobs and I only get 1 to pass :-( |
|
I know, it is now in a range of 41mins ~ 50+mins, and we are adding new test almost at each PR... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scipy.mode is a not a reliable way to compute the mode for continuous variables, I change it for a method based on kde computation.
kde_plot=Trueis now ignored for discrete variables, allowing to have kde plots (for continuous variables) with histogram (for discrete variables) in the same posterior_plot.