Skip to content

Update/Standardize Notebook: marginalized_gaussian_mixture_model #4097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AmitKus
Copy link
Contributor

@AmitKus AmitKus commented Sep 12, 2020

  1. Fix: AttributeError: 'Rectangle' object has no property 'normed'
  2. Format the notebook according to the style guide
  3. Use arviz plotting functionalities

Depending on what your PR does, here are a few things you might want to address in the description:

  • what are the (breaking) changes that this PR makes?
  • important background, or details about the implementation
  • are the changes—especially new features—covered by tests and docstrings?
  • consider adding/updating relevant example notebooks
  • right before it's ready to merge, mention the PR in the RELEASE-NOTES.md

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Sep 12, 2020

Codecov Report

Merging #4097 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4097   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files          88       88           
  Lines       13865    13865           
=======================================
  Hits        12268    12268           
  Misses       1597     1597           

@review-notebook-app
Copy link

review-notebook-app bot commented Sep 12, 2020

View / edit / reply to this conversation on ReviewNB

MarcoGorelli commented on 2020-09-12T07:46:55Z
----------------------------------------------------------------

Where it says

is available here

and it links to https://raw.githubusercontent.com/pymc-devs/pymc3/65b6b6438bd3e1389f58600db30b86f2a84d6dac/docs/source/notebooks/gaussian_mixture_model.ipynb , could the link be to https://nbviewer.jupyter.org/github/pymc-devs/pymc3/blob/master/docs/source/notebooks/gaussian_mixture_model.ipynb instead?


AmitKus commented on 2020-09-13T00:32:52Z
----------------------------------------------------------------

Done. Thanks.

Copy link
Contributor Author

AmitKus commented Sep 13, 2020

Done. Thanks.


View entire conversation on ReviewNB

Copy link
Contributor

@AlexAndorra AlexAndorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @AmitKus !

@AlexAndorra AlexAndorra merged commit 6a5b758 into pymc-devs:master Sep 13, 2020
@AmitKus AmitKus deleted the marginalized_gaussian_mixture_model branch September 13, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants