Skip to content

Update/standardize GLM-logistic notebook #4103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2020

Conversation

AmitKus
Copy link
Contributor

@AmitKus AmitKus commented Sep 16, 2020

  1. Fix AttributeError: 'Rectangle' object has no property 'normed'
  2. Upadte using the style guide
  3. Other minor changes

Thank your for opening a PR!

Depending on what your PR does, here are a few things you might want to address in the description:

  • what are the (breaking) changes that this PR makes?
  • important background, or details about the implementation
  • are the changes—especially new features—covered by tests and docstrings?
  • consider adding/updating relevant example notebooks
  • right before it's ready to merge, mention the PR in the RELEASE-NOTES.md

2. Upadte using the style guide
3. Other minor changes
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #4103 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4103   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files          89       89           
  Lines       14015    14015           
=======================================
  Hits        12440    12440           
  Misses       1575     1575           
Impacted Files Coverage Δ
pymc3/smc/sample_smc.py 87.95% <0.00%> (ø)

@MarcoGorelli
Copy link
Contributor

Hi @AmitKus

The style guide has been updated to explicitly advise keeping standard-library imports separate from third-party imports. Can you reorder the imports, or alternatively run

nbqa isort your_notebook.ipynb --treat-comment-as-code '# %%' --lines-between-types 1 --nbqa-mutate

on your notebook?

@AmitKus
Copy link
Contributor Author

AmitKus commented Sep 17, 2020

Hi @AmitKus

The style guide has been updated to explicitly advise keeping standard-library imports separate from third-party imports. Can you reorder the imports, or alternatively run

nbqa isort your_notebook.ipynb --treat-comment-as-code '# %%' --lines-between-types 1 --nbqa-mutate

on your notebook?

Thank you @MarcoGorelli. Made the changes that you suggested.

Copy link
Contributor

@AlexAndorra AlexAndorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @AmitKus !

@AlexAndorra AlexAndorra merged commit f0b9577 into pymc-devs:master Sep 17, 2020
@AmitKus AmitKus deleted the glm-logistics branch September 18, 2020 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants