-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add terms to the glossary #5014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @Guneetconvent2002, can you give more descriptive titles? |
I don't really understand what you mean by the "insert suggestion" feature. About opening a PR in those branches, the 2 PRs have 2 different branches. Which one do you want me to use? or do you want me to put a PR for merging in their repos? I'm a little unclear here |
|
@Guneetconvent2002 #4987 is probably the right one. I was referring to this feature: https://til.hashrocket.com/posts/szgdi4at59-github-insert-a-suggestion- Also the |
@michaelosthege, thank you for your guidance. I’m also newish to OS and a little unclear on the process. Originally, the glossary instructions were for each contributor to work out of their own branch, thus #4984, #4987, and #5014 were created (I assumed conflicts could be resolved by some rebasing). So what’s a principled way for several people to add to the same file simultaneously? If this PR (#5014) leads to conflict, then either #4984 or #4987 (whoever comes second?) would too - will it also be resolved by inserting suggestions? And how is #4987 “probably the right one” vs #4984. |
@olgadk7 If you're creating the document from scratch and everybody is working on all paragraphs maybe draft it in HackMD or Google Docs first? Otherwise the best way to keep PRs conflict-free is fast iteration and avoiding to edit the same file simultaneously with multiple people. |
@Guneetconvent2002 as the other PR was merged before incorporating your comments I have reopened this one and fixed the git conflicts in order to merge your contributions and give you proper attribution. |
Thank you @OriolAbril means a lot |
This reverts commit 8027751.
Made certain changes to formula for Bayes theorem