Use PEP426 environment markers for extras_require. #230
Conversation
|
This looks correct to me. |
|
Thanks so much, this looks something like what I expected too, although I really would like to get some automation before merging to make sure that this doesn't happen again. I can give that another shot hopefully tomorrow, unless you've got some ideas. Also CC @dstufft just in case I can bother you into a consult for this, context is in #228. |
|
I don't think the checking for bdist_ in args is needed: setuptools should handle the markers fine for egg_info, sdist and install too. I put up #231 before I knew this was here, it doesn't have the bdist_ checks. The basic approach is here is fine, its exactly what the wheel package does. |
|
So thanks again! I'm going to merge #231 only because the way that that looping over argv looks makes me uneasy. But I really appreciate everyone pitching in especially with the amount of time I have to think about this specifically :/ |
002ce0f Merge pull request #237 from leadpony/add_to_list 6e62399 Add Justify as a suite user to README.md 0436e52 Merge pull request #233 from leadpony/fix_indentation c09e3a6 Fix broken indentation in enum.json 353f7f3 Merge pull request #232 from Clemens-U/master aa833c5 Added a test for an invalid closing Z after time-zone offset for date-time format. c17161a Merge pull request #230 from Jokipii/master 139fb66 Add https://github.com/seznam/python-fastjsonschema to the list git-subtree-dir: json git-subtree-split: 002ce0fbe070f483429260188b18fe07bd6ec0f0
This pull request tries to address the issue #228 and introduces PEP426 compliant environment markers for the
extras_requirespecification as proposed by @takluyver.