Fix universal wheels #231
Merged
Fix universal wheels #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current universal wheels have static install_requires matching the python version they were built on: so a wheel built on 2.6 claims it needs argparse and repoze.lru on 2.7 and 3.4, etc. This clearly doesn't work :) environment markers are however honoured by wheels and pip, using this somewhat ugly syntax in extras (I'm looking to improve that, but this works - see the distutils-sig list for some discussion on it recently).
|
This should also fix #228 |
|
This is basically the same as #230 |
|
Yeah it is; it doesn't have the cruft for old setuptools; I'll leave it up to the jsonschema maintainers to decide which they want. |
|
Hey! Thanks. I'm going to merge this even though there isn't anything testing this and that makes me pretty unhappy, but I don't have the bandwidth to get that in place at this very second, and I know people are waiting, so it'll have to be circled back for. Very much appreciated, I'll try to get another release out with this change. |
|
+1 for when possible, it's Monday morning and the CI test are starting to fail in a couple of repos. |
tanaypf9
pushed a commit
to tanaypf9/pf9-requirements
that referenced
this pull request
May 20, 2024
Patch Set 1: Code-Review+2 Workflow+1 Looks from python-jsonschema/jsonschema#231 like a new release is imminent but best to have this break documented in our reqs anyway. Patch-set: 1 Reviewer: Gerrit User 5263 <5263@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+2 Label: Workflow=+1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current universal wheels have static install_requires matching the python version they were built on: so a wheel built on 2.6 claims it needs argparse and repoze.lru on 2.7 and 3.4, etc. This clearly doesn't work :)
environment markers are however honoured by wheels and pip, using this somewhat ugly syntax in extras (I'm looking to improve that, but this works - see the distutils-sig list for some discussion on it recently).