-
Notifications
You must be signed in to change notification settings - Fork 338
Make it possible to include "unused" models in the generated swagger documentation, refs #90 #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
=======================================
Coverage 96.91% 96.92%
=======================================
Files 19 19
Lines 2692 2696 +4
=======================================
+ Hits 2609 2613 +4
Misses 83 83
Continue to review full report at Codecov.
|
Hello, Thank you for your contribution. Would you mind waiting a bit for this change to come up, then updating your PR accordingly (that is adding a note in the documentation about this new option)? I have no definitive ETA but I'd like to work on this within the end of the week. |
Well, if I'm being honest, I would prefer the PR to be merged to avoid possible conflicts with other commits. You could then open a separate issue for the documentation of |
@ziirish Hi! What do you think about the solution I proposed in my previous comment? |
@ziirish Hi, any update on this? |
Thanks! As promised, I'll write the documentation for |
Perfect, thanks! |
Thanks. It's perfectly fine as it is in my opinion, but if you need any further contribution related to this feature, just let me know. If there's nothing else, then I think #90 can be closed. |
Ok great. Thanks again for your contribution. |
Thanks for accepting the PR. |
Are you able to deploy a release with this change? Thanks! Some context - We have an endpoint that returns a polymorphic response. The different response types are defined using api.model but they are not available for a reference in the schema definitions. |
Changes:
RESTX_INCLUDE_ALL_MODELS
config option with aFalse
default value.Swagger.as_dict()
now adds all existing models to the documentation ifRESTX_INCLUDE_ALL_MODELS
is set.RESTX_INCLUDE_ALL_MODELS
.