Skip to content

adding a binder badge #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2019
Merged

adding a binder badge #1137

merged 2 commits into from
May 4, 2019

Conversation

vbergste
Copy link
Contributor

@vbergste vbergste commented May 4, 2019

added a binder badge to the examples folder

vbergste added 2 commits May 4, 2019 12:09
Added a binder button to launch jupyter notebook
@ocefpaf
Copy link
Member

ocefpaf commented May 4, 2019

Hi @vbergste, this is an awesome addition. Thanks for doing it. You will notice the Continuous Integrations tests running below. In this case, because you did not changed the code, you don't need to wait for them to finish to merge it.

@ocefpaf ocefpaf merged commit c5de6e2 into python-visualization:master May 4, 2019
@ocefpaf
Copy link
Member

ocefpaf commented May 4, 2019

They @Conengmo, we are at PyCon for a mentored sprint and I will be merging a few PRs like this. Just wanted to let you know.

@Conengmo
Copy link
Member

Conengmo commented May 5, 2019

Hi @ocefpaf, thanks for the message. Just saw a long list with notifications so I already wondered what was going on :p cool that you’re doing this! Let me know if I can help you with something.

@ocefpaf
Copy link
Member

ocefpaf commented May 5, 2019

Let me know if I can help you with something.

Take a quick look at PRs #1140 and #1144. It will be nice for the sprint attendees to get feedback from someone off-site (which is 99.99% the time the normal way we do things on GitHub ;-p).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants