Skip to content

added simple example using flask #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 26, 2019

Conversation

GiantRobato
Copy link
Contributor

Added

  • example on how to use folium with flask

@ocefpaf
Copy link
Member

ocefpaf commented May 5, 2019

Awesome! Thanks @penguindustin!! This question pops up so frequently that it is a great addition to our docs. I'll leave it here for a while so @Conengmo can take a quick look at but I'm planning to merge it during the rest of the sprints.

@ocefpaf ocefpaf mentioned this pull request May 5, 2019
@GiantRobato
Copy link
Contributor Author

@ocefpaf thanks for the mentoring! I enjoyed working on the project 😊

Copy link
Member

@Conengmo Conengmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @penguindustin! I think it's a good idea to have an example on how to use folium with Flask.

In your PR you add basically the same example in two places: in the documentation and in a Python file in our examples folder. I think it would be best to choose one those and not have a duplicate example in two places. Which do you think is better, the documentation or the example file? I'm currently leaning towards the example Python file.

@GiantRobato
Copy link
Contributor Author

@Conengmo I reordered the index and added some extra info to the example file. Should I replicate it in the .rst? I think there's a way to reference the actual python file instead of copy pasta into the .rst but I'm no expert in Sphinx docs.

@ocefpaf
Copy link
Member

ocefpaf commented May 26, 2019

@Conengmo I think it is nice to have it in the docs and the best course of action, to avoid the duplication of code and changes of it going stale, is to reference the example file in the rst as @penguindustin suggests. I'm looking into how to do that.

@ocefpaf ocefpaf force-pushed the add-flask-examples branch from bf2ac63 to a88d68f Compare May 26, 2019 18:41
@ocefpaf ocefpaf merged commit 6986a9e into python-visualization:master May 26, 2019
@ocefpaf
Copy link
Member

ocefpaf commented May 26, 2019

Thanks @penguindustin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants