Explicit key_of_x check
#1169
Merged
Explicit key_of_x check
#1169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Jun 22, 2019
Conengmo
reviewed
Jul 21, 2019
There was a problem hiding this comment.
This looks good! Thanks for your PR @LeandroOrdonez. I have one comment about the test, please have a look. Should be easy to resolve, we can merge this afterwards.
Conengmo
added
waiting for changes
Conengmo
removed
the
waiting for changes
|
Thanks @LeandroOrdonez for your contribution! |
|
Happy to help @Conengmo! Keep up the good work! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An explicit check for None (
key_of_x == None) in thecolor_scale_fun(x)method from classfolium.features.Choroplethhas been added, along with the corresponding (provisional?) test.Closes #1168