Fix issue #252

[BibMartin]

For the pleasure to do a 2 characters PR.
Tests will come later

[ocefpaf]

I wonder if I will have time to read all those changes!!!

[themiurgo]

😀

[ocefpaf]

I am merging this, but let's leave #252 open until we have some tests.

BTW I tested this and it works. I did not know about |e. Awesome to learn something new! I was going to use the messy .encode('ascii', 'xmlcharrefreplace') like we had before.

[BibMartin]

I did not know about |e. Awesome to learn something new!

It's new to me also ; thank you duckduckgo. But it does not transform non-ASCII characters. Try with "Ça c'est chouette". I guess there's something about encoding/decoding things also.

[ocefpaf]

But it does not transform non-ASCII characters.

Good to know. I am trying to design tests for this and I will add a failing test for Ça c'est chouette.

[ocefpaf]

Thanks @BibMartin! I am writing some tests for test. Hopefully I will have something ready tomorrow.

[themiurgo]

This is amazing. An issue closed in a few hours. :)

[ocefpaf]

Well. Let's not close the issue until we have the tests in place 😺