Popup tests #254
Popup tests #254
Conversation
|
This PR is not ready. We need:
|
|
|
||
| def test_popup_ascii(): | ||
| popup = Popup('Some text.') | ||
| _id = list(popup.html._children.items())[0][0] |
There was a problem hiding this comment.
@BibMartin do you have a better suggestion than this?
There was a problem hiding this comment.
I would have done
_id = list(popup.html._children.keys())[0]
but it's really equivalent.
There was a problem hiding this comment.
but it's really equivalent.
The result? Yes. But your way is more readable. Changing that...
|
@ocefpaf This list might help in building strong tests. |
Thanks! I will take a look. (I like the name 😉) |
ocefpaf
added
bug
ocefpaf
force-pushed
the
popup_tests
branch
3 times, most recently
from
5368adc to
477884c
Compare
|
@BibMartin can you review and merge. I will add more tests later on. |
| @@ -5,6 +5,9 @@ | |||
|
|
|||
| Classes for drawing maps. | |||
| """ | |||
|
|
|||
| from __future__ import unicode_literals | |||
There was a problem hiding this comment.
@ocefpaf
Just for curiosity: what is it for ?
There was a problem hiding this comment.
So we can use "Ça c'est chouette" instead of u"Ça c'est chouette". Embrace the future 😉
|
It's ok. Merging 🎉 |
|
Thanks! |
Complements #253 and closes #252.
NB the
test_popup_unicodeis a known failure.