Skip to content

Add style_function to TopoJson #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2016

Conversation

BibMartin
Copy link
Contributor

addresses #316

Not finished ; I guess tests will need an update and an example could be good.

@BibMartin BibMartin mentioned this pull request Jan 14, 2016
@ocefpaf
Copy link
Member

ocefpaf commented Jan 14, 2016

Not finished ; I guess tests will need an update

I guess you updated them, right? Or do you want to add something extra?

and an example could be good.

That can be added later if you think this is ready to be merged.

@ocefpaf
Copy link
Member

ocefpaf commented Jan 14, 2016

BTW here is @alexandercbooth example using this PR:

http://nbviewer.ipython.org/gist/ocefpaf/ae22bd2ee2d4f86abffd

ocefpaf added a commit that referenced this pull request Jan 15, 2016
Add style_function to TopoJson
@ocefpaf ocefpaf merged commit 1d52280 into python-visualization:master Jan 15, 2016
@ocefpaf ocefpaf added the bug An issue describing unexpected or malicious behaviour label Feb 12, 2016
@ocefpaf ocefpaf added this to the v0.2.0 milestone Feb 12, 2016
@ocefpaf ocefpaf added enhancement Feature request or idea about how to make folium better and removed bug An issue describing unexpected or malicious behaviour labels Feb 12, 2016
sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or idea about how to make folium better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants