Switch to non-minified leaflet.awesome-markers #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes python-visualization#505 The minified version of leaflet.awesome-markers has a problem with correctly passing the extraClasses option to the <i> tags 'class' attribute, causing the fa-rotate-* classes not to be applied correctly. As a workaround, switch to using the non-minified version of leaflet.awesome-markers that works correctly.
Merged
ocefpaf
reviewed
Oct 20, 2016
| @@ -5,7 +5,7 @@ | |||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/leaflet/0.7.3/leaflet.js"></script> | |||
| <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script> | |||
| <script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.2.0/js/bootstrap.min.js"></script> | |||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/Leaflet.awesome-markers/2.0.2/leaflet.awesome-markers.min.js"></script> | |||
There was a problem hiding this comment.
@sseemayer this is only the template for the tests, but you are in the right direction. I think that #530 nails it though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #505
The minified version of leaflet.awesome-markers has a problem with
correctly passing the extraClasses option to the tags 'class'
attribute, causing the fa-rotate-* classes not to be applied correctly.
As a workaround, switch to using the non-minified version of
leaflet.awesome-markers that works correctly.