Skip to content

Fix rotation #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2016
Merged

Fix rotation #530

merged 2 commits into from
Oct 20, 2016

Conversation

juoceano
Copy link
Contributor

Finishes #527

@sseemayer
Switch to non-minified leaflet.awesome-markers
15c5650 
Fixes python-visualization#505

The minified version of leaflet.awesome-markers has a problem with
correctly passing the extraClasses option to the <i> tags 'class'
attribute, causing the fa-rotate-* classes not to be applied correctly.

As a workaround, switch to using the non-minified version of
leaflet.awesome-markers that works correctly.
@ocefpaf ocefpaf mentioned this pull request Oct 20, 2016
Merged
@ocefpaf
Copy link
Member

ocefpaf commented Oct 20, 2016 •
edited
Loading

LGTM! See https://nbviewer.ipython.org/gist/ocefpaf/74344a795e1a2a84da189884989ada40

Thanks!

@ocefpaf ocefpaf merged commit f6fce3c into python-visualization:master Oct 20, 2016
@juoceano juoceano deleted the fix_rotation branch October 20, 2016 15:03
sanga pushed a commit to sanga/folium that referenced this pull request Oct 24, 2017
@ocefpaf
Merge pull request python-visualization#530 from juoceano/fix_rotation
3091bc4 
Fix rotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juoceano @ocefpaf @sseemayer