Document how to update SQLite source dependencies. #3
Conversation
Update the README with the instructions. Use ReST.
README.rst
Outdated
|
|
||
| 6. Create the PR, with ``sqlite`` as the base branch. | ||
|
|
||
| Once the PR has been merged, tag the commit as ``sqlite-<full version specified in CPython's PCbuild/get_externals.bat>``. |
README.rst
Outdated
|
|
||
| .. contents:: | ||
|
|
||
| Updating SQLite Source Dependencies |
There was a problem hiding this comment.
I think we can generalize this. Most dependencies (sqlite, bzip2, xz, zlib) follow the same instructions; tcl and tk also follow the same instructions, but have an extra step afterwards that @zooba has to do (updating cpython-bin-deps); openssl will have a much-expanded step 5. Maybe leave the steps below as is, but note that sqlite is just used an an example, and the same steps apply to the ones I listed above?
There was a problem hiding this comment.
Thanks :) so I tried my best at explaining that the other dependencies can be updated in similar fashion. Hope the latest change makes sense..
| <https://github.com/python/cpython-bin-deps/>`_ | ||
| needs to be updated. | ||
|
|
||
| For ``openssl``, step 5 will be more complicated :) |
There was a problem hiding this comment.
For each of these, we can link to the source site:
sqlite: https://www.sqlite.org/download.html
bzip2: http://www.bzip.org/downloads.html
xz: https://tukaani.org/xz/
zlib: https://zlib.net/
tcl/tk: https://tcl.tk/software/tcltk/download.html
openssl: https://www.openssl.org/source/
There was a problem hiding this comment.
Thanks, I added a "Download links" section listing the above.
README.rst
Outdated
| @@ -19,13 +23,32 @@ Updating SQLite Source Dependencies | |||
|
|
|||
| git checkout -b <branch-name>-sqlite upstream/sqlite | |||
|
|
|||
| 3. Download SQLite source from ``sqlite.org``. | |||
| 3. Download SQLite source from `sqlite.org <https://www.sqlite.org>`_. | |||
|
|
|||
| 4. Unzip it to the checked out branch on step 2. | |||
There was a problem hiding this comment.
s/checked out branch on/branch checked out in/
README.rst
Outdated
| @@ -19,13 +23,32 @@ Updating SQLite Source Dependencies | |||
|
|
|||
| git checkout -b <branch-name>-sqlite upstream/sqlite | |||
|
|
|||
| 3. Download SQLite source from ``sqlite.org``. | |||
| 3. Download SQLite source from `sqlite.org <https://www.sqlite.org>`_. | |||
There was a problem hiding this comment.
We should add checking the hash to this step.
|
Thanks @Mariatta :) |
Update the README with the instructions.
Use ReST.