Skip to content

Document how to update SQLite source dependencies. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 21, 2017
Merged

Document how to update SQLite source dependencies. #3

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7ef1a5
Document how to update SQLite source dependencies.
Mariatta Nov 4, 2017
58f76f8
Use double backticks.
Mariatta Nov 4, 2017
5df7c99
Explain that other dependencies follow the similar procedure.
Mariatta Nov 5, 2017
9ff68ef
Add Download links section.
Mariatta Nov 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions README.md
View file
Open in desktop

This file was deleted.

31 changes: 31 additions & 0 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
cpython-source-deps
===================

Source for packages that the CPython build process depends on.

It is currently expected that this will only be useful on Windows,
and in any case you should never need to clone this repository
unless you are updating its contents.

.. contents::

Updating SQLite Source Dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can generalize this. Most dependencies (sqlite, bzip2, xz, zlib) follow the same instructions; tcl and tk also follow the same instructions, but have an extra step afterwards that @zooba has to do (updating cpython-bin-deps); openssl will have a much-expanded step 5. Maybe leave the steps below as is, but note that sqlite is just used an an example, and the same steps apply to the ones I listed above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) so I tried my best at explaining that the other dependencies can be updated in similar fashion. Hope the latest change makes sense..

-----------------------------------

1. Fork and clone this repository.

2. Checkout a new branch off the ``sqlite`` branch. Assuming this repo is set
as your ``upstream``::

git checkout -b <branch-name>-sqlite upstream/sqlite

3. Download SQLite source from ``sqlite.org``.

4. Unzip it to the checked out branch on step 2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/checked out branch on/branch checked out in/


5. Commit and push the changes.

6. Create the PR, with ``sqlite`` as the base branch.

Once the PR has been merged, tag the commit as ``sqlite-<full version specified in CPython's PCbuild/get_externals.bat>``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/specified/to be used/