gh-75743: Restore test_timeout.testConnectTimeout() #109087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This un-skips this test now that pythontest.net implements appropriate firewall rules for it.
vstinner
reviewed
Sep 7, 2023
Ref: python/psf-salt@0e2a423 RETURN was relying on default REJECT, explicitly REJECT in INPUT
|
@ewdurbin: Whaaaaaaaaat? I was awaiting for that service for years, and you made it possible in 3 hours? I'm... amazed! Thanks a lot 🙏 |
vstinner
added
needs backport to 3.11
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 7, 2023
…09087) This un-skips this test now that pythontest.net implements appropriate firewall rules for it. (cherry picked from commit 1829a3c) Co-authored-by: Ee Durbin <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 7, 2023
…09087) This un-skips this test now that pythontest.net implements appropriate firewall rules for it. (cherry picked from commit 1829a3c) Co-authored-by: Ee Durbin <[email protected]>
|
GH-109102 is a backport of this pull request to the 3.11 branch. |
|
GH-109103 is a backport of this pull request to the 3.12 branch. |
bedevere-bot
removed
needs backport to 3.11
|
Merged, thanks again @ewdurbin! |
vstinner
pushed a commit
that referenced
this pull request
Sep 7, 2023
#109102) gh-75743: Restore test_timeout.testConnectTimeout() (GH-109087) This un-skips this test now that pythontest.net implements appropriate firewall rules for it. (cherry picked from commit 1829a3c) Co-authored-by: Ee Durbin <[email protected]>
Yhg1s
pushed a commit
that referenced
this pull request
Sep 8, 2023
#109103) gh-75743: Restore test_timeout.testConnectTimeout() (GH-109087) This un-skips this test now that pythontest.net implements appropriate firewall rules for it. (cherry picked from commit 1829a3c) Co-authored-by: Ee Durbin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This un-skips this test now that pythontest.net implements appropriate firewall rules for it.
Alternative to #109060