Skip to content

gh-75743: Remove test_timeout.testConnectTimeout() #109060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 7, 2023

Remove test_timeout.testConnectTimeout() which is always skipped since 2009, commit 5b95a15.

No replacement was found for blackhole.snakebite.net and whitehole.snakebite.net online servers.

Remove test_timeout.testConnectTimeout() which is always skipped
since 2009, commit 5b95a15.

No replacement was found for blackhole.snakebite.net and
whitehole.snakebite.net online servers.
@vstinner
Copy link
Member Author

vstinner commented Sep 7, 2023

cc @serhiy-storchaka

I don't think that it's worth it to backport this change to stable branches (Python 3.11 and 3.12).

ewdurbin added a commit to python/psf-salt that referenced this pull request Sep 7, 2023
Replaces functionality of blackhole.snakebite.net and whitehole.snakebite.net

Ref: python/cpython#75743
Ref: python/cpython#109060
@ewdurbin
Copy link
Member

ewdurbin commented Sep 7, 2023

Thanks for flagging me @serhiy-storchaka, first I've heard of this :)

python/psf-salt@ed19ff8 Adds firewall rules so that

pythontest.net:56666 works a stand in for blackhole.snakebite.net:56666
and
pythontest.net:56667 works a stand in for whitehole.snakebite.net:56667

If there's interest in retaining the test.

@serhiy-storchaka
Copy link
Member

Thank you @ewdurbin!

Do you mind to create a PR? You better know what should be changed in comments (currently they contain a recipe for BSD).

@ewdurbin
Copy link
Member

ewdurbin commented Sep 7, 2023

Sure. I'll send a PR.

@ewdurbin
Copy link
Member

ewdurbin commented Sep 7, 2023

@serhiy-storchaka see #109087.

@tpn
Copy link
Member

tpn commented Sep 7, 2023

Awesome to see this finally get resolved, some 12-13 years after I initially set up the OpenBSD pf rules on Snakebite :-)

@vstinner
Copy link
Member Author

vstinner commented Sep 7, 2023

@serhiy-storchaka see #109087.

Running tests is way better than removing them, I close my PR.

@vstinner vstinner closed this Sep 7, 2023
@vstinner vstinner deleted the remove_snakebite branch September 7, 2023 15:53
@vstinner
Copy link
Member Author

vstinner commented Sep 7, 2023

Awesome to see this finally get resolved, some 12-13 years after I initially set up the OpenBSD pf rules on Snakebite :-)

Thanks for snakebites @tpn, it was a great service! I recall it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants