-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-75743: Remove test_timeout.testConnectTimeout() #109060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove test_timeout.testConnectTimeout() which is always skipped since 2009, commit 5b95a15. No replacement was found for blackhole.snakebite.net and whitehole.snakebite.net online servers.
I don't think that it's worth it to backport this change to stable branches (Python 3.11 and 3.12). |
5ec2ae9
to
a3ebdae
Compare
Replaces functionality of blackhole.snakebite.net and whitehole.snakebite.net Ref: python/cpython#75743 Ref: python/cpython#109060
Thanks for flagging me @serhiy-storchaka, first I've heard of this :) python/psf-salt@ed19ff8 Adds firewall rules so that
If there's interest in retaining the test. |
Thank you @ewdurbin! Do you mind to create a PR? You better know what should be changed in comments (currently they contain a recipe for BSD). |
Sure. I'll send a PR. |
@serhiy-storchaka see #109087. |
Awesome to see this finally get resolved, some 12-13 years after I initially set up the OpenBSD pf rules on Snakebite :-) |
Running tests is way better than removing them, I close my PR. |
Thanks for snakebites @tpn, it was a great service! I recall it :-) |
Remove test_timeout.testConnectTimeout() which is always skipped since 2009, commit 5b95a15.
No replacement was found for blackhole.snakebite.net and whitehole.snakebite.net online servers.