Skip to content

bpo-35899: Fix Enum handling of empty and weird strings #11891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 3, 2019
Merged

bpo-35899: Fix Enum handling of empty and weird strings #11891

merged 7 commits into from
Mar 3, 2019

Conversation

bdbaraban
Copy link
Contributor

@bdbaraban bdbaraban commented Feb 16, 2019 •
edited by bedevere-bot
Loading

Co-authored-by: Maxwell [email protected]
Co-authored-by: Stéphane Wirtel [email protected]

https://bugs.python.org/issue35899

matrixise
matrixise approved these changes Feb 18, 2019
View reviewed changes
Copy link
Member

@matrixise matrixise left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for your contribution.

@matrixise
Copy link
Member

@ethanfurman do you want to review/merge this PR?

Have a nice day,

@ethanfurman ethanfurman self-assigned this Feb 21, 2019
ethanfurman
ethanfurman requested changes Feb 21, 2019
View reviewed changes
Copy link
Member

@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good! A couple more changes and this should be ready to go.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@bdbaraban
Copy link
Contributor Author

I have made the requested changes; please review again

Thank you, Ethan. I've updated both files accordingly.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

ethanfurman
ethanfurman requested changes Mar 3, 2019
View reviewed changes
Copy link
Member

@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more minor change and this PR is good to go! Nice work!

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@miss-islington
Copy link
Contributor

@bdbaraban: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 8b914d2 into python:master Mar 3, 2019
@miss-islington
Copy link
Contributor

Thanks @bdbaraban for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2019
@bdbaraban @miss-islington
bpo-35899: Fix Enum handling of empty and weird strings (pythonGH-11891)
7b5c54d 
Co-authored-by: Maxwell <[email protected]>
Co-authored-by: Stéphane Wirtel <[email protected]>

https://bugs.python.org/issue35899
(cherry picked from commit 8b914d2)

Co-authored-by: Brennan D Baraban <[email protected]>
@bedevere-bot
Copy link

GH-12150 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-12151 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 3, 2019
@bdbaraban @miss-islington
bpo-35899: Fix Enum handling of empty and weird strings (pythonGH-11891)
6d079ff 
Co-authored-by: Maxwell <[email protected]>
Co-authored-by: Stéphane Wirtel <[email protected]>

https://bugs.python.org/issue35899
(cherry picked from commit 8b914d2)

Co-authored-by: Brennan D Baraban <[email protected]>
@bdbaraban bdbaraban deleted the fix-issue-35899 branch March 3, 2019 22:28
@remilapeyre remilapeyre mentioned this pull request Mar 6, 2019
Closed
miss-islington added a commit that referenced this pull request Mar 8, 2019
@miss-islington @bdbaraban
bpo-35899: Fix Enum handling of empty and weird strings (GH-11891)
8755f0a 
Co-authored-by: Maxwell <[email protected]>
Co-authored-by: Stéphane Wirtel <[email protected]>

https://bugs.python.org/issue35899
(cherry picked from commit 8b914d2)

Co-authored-by: Brennan D Baraban <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matrixise matrixise matrixise approved these changes

@ethanfurman ethanfurman ethanfurman approved these changes

Assignees

@ethanfurman ethanfurman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bdbaraban @matrixise @bedevere-bot @miss-islington @ethanfurman @the-knights-who-say-ni @234761