Skip to content

gh-58282: Fix support of tuple metavar for positional arguments in argparse #124782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 30, 2024

Previously, formatting help output or error message for positional argument with a tuple metavar raised exception.

Co-authored-by: Cyker Way [email protected]

… in argparse

Previously, formatting help output or error message for positional argument
with a tuple metavar raised exception.

Co-authored-b: Cyker Way <[email protected]>
Copy link
Member

@savannahostrowski savannahostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to me. Thanks for adding so many test cases!

@serhiy-storchaka
Copy link
Member Author

Thank you for your review, @savannahostrowski.

@serhiy-storchaka serhiy-storchaka merged commit 9b31a2d into python:main Oct 2, 2024
34 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the argparse-metavar-tuple branch October 2, 2024 08:28
@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9b31a2d83fa7cb0fe4d75ce7cf6a2c9ea2ce0728 3.13

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2024
… in argparse (pythonGH-124782)

Previously, formatting help output or error message for positional argument
with a tuple metavar raised exception.

(cherry picked from commit 9b31a2d)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Cyker Way <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 2, 2024

GH-124881 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 2, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 2, 2024
…guments in argparse (pythonGH-124782)

Previously, formatting help output or error message for positional argument
with a tuple metavar raised exception.

(cherry picked from commit 9b31a2d)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Cyker Way <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 2, 2024

GH-124882 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 2, 2024
@serhiy-storchaka serhiy-storchaka removed their assignment Oct 2, 2024
serhiy-storchaka added a commit that referenced this pull request Oct 2, 2024
…s in argparse (GH-124782) (GH-124881)

Previously, formatting help output or error message for positional argument
with a tuple metavar raised exception.

(cherry picked from commit 9b31a2d)

Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Cyker Way <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Oct 8, 2024
…s in argparse (GH-124782) (GH-124882)

Previously, formatting help output or error message for positional argument
with a tuple metavar raised exception.

(cherry picked from commit 9b31a2d)

Co-authored-by: Cyker Way <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants