Skip to content

bpo-42547: fix add_argument(metavar=<tuple>, nargs='+') for positional arguments #23617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

m-khvoinitsky
Copy link

@m-khvoinitsky m-khvoinitsky commented Dec 2, 2020

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@m-khvoinitsky

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

metavar, = self._metavar_formatter(action, default)(1)
metavar = self._metavar_formatter(action, default)(1)[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but there really needs to be a unit test for this change.

@@ -0,0 +1 @@
argparse: fixed `add_argument(metavar=<tuple>, nargs='+')` for positional arguments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more details and use full sentences. Code snippets should be enclosed in double backquotes.

Please replace "argparse" with

:mod:`argparse`

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 12, 2021
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 1, 2022
@serhiy-storchaka
Copy link
Member

Thank you for your PR, @m-khvoinitsky, but it was not be merged dues to lack of tests. And tests could show that these changes are not enough.

#124782 is a more complete solution for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants