Skip to content

bpo-39759: fixed os.getenv docs #18668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

bpo-39759: fixed os.getenv docs #18668

wants to merge 3 commits into from

Conversation

dorosch
Copy link
Contributor

@dorosch dorosch commented Feb 26, 2020 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 26, 2020
remilapeyre
remilapeyre reviewed Feb 26, 2020
View reviewed changes
remilapeyre
remilapeyre approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

serhiy-storchaka
serhiy-storchaka reviewed Jul 4, 2021
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix also the documentation for getenvb.

@slateny
Copy link
Contributor

slateny commented Sep 26, 2022

@dorosch Would you still be interested in updating this PR per Serhiy's comment?

@serhiy-storchaka
Copy link
Member

The proposed change removes a useful information: that the result is a string if the key is found (and it is a bytes object in os.getenvv()). This information should be preserved.

Also, the docstrings say the same as the documentation, so it should be updated correspondingly.

@slateny
Copy link
Contributor

slateny commented Oct 2, 2022

Will start on a new PR here then, let me know if you'd still like to work on this one.

@slateny
Copy link
Contributor

slateny commented Oct 9, 2022

See #98113

@slateny slateny closed this Oct 9, 2022
@remilapeyre remilapeyre mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@remilapeyre remilapeyre remilapeyre approved these changes

Assignees
No one assigned
Labels
awaiting core review docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dorosch @slateny @serhiy-storchaka @remilapeyre @the-knights-who-say-ni @ezio-melotti @bedevere-bot