gh-83940: Remove os.env/b default type constraint in os docs #98113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doc/library/os.rst
Outdated
| @@ -305,7 +305,7 @@ process and user. | |||
| .. function:: getenv(key, default=None) | |||
|
|
|||
| Return the value of the environment variable *key* if it exists, or | |||
| *default* if it doesn't. *key*, *default* and the result are str. Note that | |||
| *default* if it doesn't. *key* and the result are strings. Note that | |||
There was a problem hiding this comment.
The result isn't a string if default isn't one. I'd suggest "Return the value of the environment variable key as a string if it exists, or default if it doesn't. key is a string."
JelleZijlstra
approved these changes
Oct 10, 2022
JelleZijlstra
added
needs backport to 3.10
|
Thanks @slateny for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-98149 is a backport of this pull request to the 3.11 branch. |
|
GH-98150 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2022
…-98113) (cherry picked from commit 187e853) Co-authored-by: Stanley <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2022
…-98113) (cherry picked from commit 187e853) Co-authored-by: Stanley <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Oct 10, 2022
(cherry picked from commit 187e853) Co-authored-by: Stanley <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Oct 10, 2022
(cherry picked from commit 187e853) Co-authored-by: Stanley <[email protected]>
mpage
pushed a commit
to mpage/cpython
that referenced
this pull request
Oct 11, 2022
pablogsal
pushed a commit
that referenced
this pull request
Oct 22, 2022
(cherry picked from commit 187e853) Co-authored-by: Stanley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.