-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
bpo-43928: Fix a typo in document #25569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The boolean predicate was typo in documentation.
Incorrect spelling, explanation: succesfully is a wrong form, because in the noun that this word comes from, success, there are two s’a. Double consonant s remained with adjective successful and then in adverbial form successfully, which is the only correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the PR!
Copied from #25568:
Oh, I see your key point, it's my mistake. But was it closed too fast? I still have the commits need to merge. I just found it was closed.
If the PR isn't ready, you can convert to draft first https://github.blog/changelog/2020-04-08-convert-pull-request-to-draft/ . Once it's ready, you can mark it as ready :).
@Fidget-Spinner Hope you have a good day! : D |
Thanks @jeffreytse for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
Sorry, @jeffreytse and @terryjreedy, I could not cleanly backport this to |
Sorry @jeffreytse and @terryjreedy, I had trouble checking out the |
Not worth backporting, if indeeded needed. |
Incorrect spelling, explanation: succesfully is a wrong form, because in the noun that this word comes from, success, there are two s’a. Double consonant s remained with adjective successful and then in adverbial form successfully, which is the only correct spelling.
https://bugs.python.org/issue43928