Skip to content

bpo-43928: Fix a typo in document #25569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2021
Merged

Conversation

jeffreytse
Copy link
Contributor

@jeffreytse jeffreytse commented Apr 24, 2021

Incorrect spelling, explanation: succesfully is a wrong form, because in the noun that this word comes from, success, there are two s’a. Double consonant s remained with adjective successful and then in adverbial form successfully, which is the only correct spelling.

https://bugs.python.org/issue43928

The boolean predicate was typo in documentation.
Incorrect spelling, explanation: succesfully is a wrong form, because
in the noun that this word comes from, success, there are two s’a.
Double consonant s remained with adjective successful and then in
adverbial form successfully, which is the only correct.
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

Copied from #25568:

Oh, I see your key point, it's my mistake. But was it closed too fast? I still have the commits need to merge. I just found it was closed.

If the PR isn't ready, you can convert to draft first https://github.blog/changelog/2020-04-08-convert-pull-request-to-draft/ . Once it's ready, you can mark it as ready :).

@jeffreytse
Copy link
Contributor Author

@Fidget-Spinner Hope you have a good day! : D

@miss-islington
Copy link
Contributor

Thanks @jeffreytse for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @jeffreytse and @terryjreedy, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e08c67372d62236409da296353827985a3202e8a 3.9

@miss-islington
Copy link
Contributor

Sorry @jeffreytse and @terryjreedy, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e08c67372d62236409da296353827985a3202e8a 3.8

@terryjreedy
Copy link
Member

Not worth backporting, if indeeded needed.

@jeffreytse jeffreytse deleted the fix-issue-43928 branch May 12, 2021 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants