Skip to content

bpo-44125: Fix "make patchcheck" on non-English locale #26102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2021

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented May 13, 2021

The patch from bpo-44074 does not account for a possibly non-English locale and blindly greps for "HEAD branch" in a possibly localized text.

https://bugs.python.org/issue44125

Automerge-Triggered-By: GH:pitrou

Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch, @pitrou !

@miss-islington
Copy link
Contributor

@pitrou: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 1aa3530 into python:main May 13, 2021
@miss-islington
Copy link
Contributor

Thanks @pitrou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2021
The patch from [bpo-44074]() does not account for a possibly non-English locale and blindly greps for "HEAD branch" in a possibly localized text.

Automerge-Triggered-By: GH:pitrou
(cherry picked from commit 1aa3530)

Co-authored-by: Antoine Pitrou <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 13, 2021
@bedevere-bot
Copy link

GH-26105 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2021
The patch from [bpo-44074]() does not account for a possibly non-English locale and blindly greps for "HEAD branch" in a possibly localized text.

Automerge-Triggered-By: GH:pitrou
(cherry picked from commit 1aa3530)

Co-authored-by: Antoine Pitrou <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 13, 2021
@bedevere-bot
Copy link

GH-26106 is a backport of this pull request to the 3.9 branch.

@pitrou pitrou deleted the bpo-44125-patchcheck branch May 13, 2021 17:49
miss-islington added a commit that referenced this pull request May 13, 2021
The patch from [bpo-44074]() does not account for a possibly non-English locale and blindly greps for "HEAD branch" in a possibly localized text.

Automerge-Triggered-By: GH:pitrou
(cherry picked from commit 1aa3530)

Co-authored-by: Antoine Pitrou <[email protected]>
miss-islington added a commit that referenced this pull request May 13, 2021
The patch from [bpo-44074]() does not account for a possibly non-English locale and blindly greps for "HEAD branch" in a possibly localized text.

Automerge-Triggered-By: GH:pitrou
(cherry picked from commit 1aa3530)

Co-authored-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants