Skip to content

[3.10] bpo-44125: Fix "make patchcheck" on non-English locale (GH-26102) #26105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 13, 2021

The patch from bpo-44074 does not account for a possibly non-English locale and blindly greps for "HEAD branch" in a possibly localized text.

(cherry picked from commit 1aa3530)

Co-authored-by: Antoine Pitrou [email protected]

https://bugs.python.org/issue44125

Automerge-Triggered-By: GH:pitrou

The patch from [bpo-44074]() does not account for a possibly non-English locale and blindly greps for "HEAD branch" in a possibly localized text.

Automerge-Triggered-By: GH:pitrou
(cherry picked from commit 1aa3530)

Co-authored-by: Antoine Pitrou <[email protected]>
@miss-islington
Copy link
Contributor Author

@pitrou: Status check is done, and it's a success ❌ .

@miss-islington
Copy link
Contributor Author

@pitrou: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: 2 of 5 required status checks are expected..

@miss-islington
Copy link
Contributor Author

@pitrou: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 336dc52 into python:3.10 May 13, 2021
@miss-islington miss-islington deleted the backport-1aa3530-3.10 branch May 13, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants