Skip to content

bpo-30913: IDLE: Document tk vars, attributes, and methods for configdialog #2697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 14, 2017
Merged

bpo-30913: IDLE: Document tk vars, attributes, and methods for configdialog #2697

merged 4 commits into from
Jul 14, 2017

Conversation

csabella
Copy link
Contributor

No description provided.

@mention-bot
Copy link

@csabella, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terryjreedy, @mlouielu and @kbkaiser to be potential reviewers.

@mlouielu
Copy link
Contributor

Do we need to document "method" in method? I thought that only needs to doc in class, not class' method.

@terryjreedy terryjreedy merged commit 36329a4 into python:master Jul 14, 2017
terryjreedy pushed a commit to terryjreedy/cpython that referenced this pull request Jul 14, 2017
@csabella @terryjreedy
[3.6] bpo-30913: IDLE: Document tk vars, attributes, and methods for …
8abbec9 
…ConfigDialog (pythonGH-2697)

The will help writing dialog improvements and splitting the class into multiple classes.
Original patch by Cheryl Sabella.
(cherry picked from commit 36329a4)
@terryjreedy terryjreedy mentioned this pull request Jul 14, 2017
Merged
terryjreedy added a commit that referenced this pull request Jul 14, 2017
@terryjreedy
[3.6] bpo-30913: IDLE: Document tk vars, attributes, and methods for …
9a09c66 
…ConfigDialog (GH-2697) (#2702)

The will help writing dialog improvements and splitting the class into multiple classes.
Original patch by Cheryl Sabella.
(cherry picked from commit 36329a4)
@csabella csabella deleted the bpo30913 branch July 14, 2017 12:09
@csabella
Copy link
Contributor Author

@mlouielu
I don't think documenting methods within methods is typical, but, in this case, Terry wanted to do so in order to convert these methods into classes. Documenting it now both simplifies the refactoring and the docs can then be used within the class.

@terryjreedy
Copy link
Member

The grouping by tab page will immediately help with writing corresponding testcase classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csabella @mention-bot @mlouielu @terryjreedy @the-knights-who-say-ni