Skip to content

bpo-46358: modernize test_asyncio #30562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 13, 2022
Merged

bpo-46358: modernize test_asyncio #30562

merged 4 commits into from
Jan 13, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 12, 2022 •
edited
Loading

What do you think: should this be backported?

CC @corona10 as my mentor.

https://bugs.python.org/issue46358

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 12, 2022
@sobolevn
Copy link
Member Author

I also found the same pattern in test_future.py. Adding it as well.

@sobolevn
Copy link
Member Author

And two cases in test_events.py

@sobolevn sobolevn changed the title bpo-46358: modernize test_asyncio/test_base_events.py bpo-46358: modernize test_asyncio Jan 12, 2022
hugovk
hugovk reviewed Jan 13, 2022
View reviewed changes
@sobolevn sobolevn closed this Jan 13, 2022
@sobolevn sobolevn reopened this Jan 13, 2022
corona10
corona10 approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 merged commit f779fac into python:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk left review comments

@corona10 corona10 corona10 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @hugovk @corona10 @bedevere-bot