Skip to content

_pickle: Fix whichmodule() #3358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2017
Merged

_pickle: Fix whichmodule() #3358

merged 1 commit into from
Sep 5, 2017

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 5, 2017

_PyUnicode_FromId() can return NULL: replace Py_INCREF() with
Py_XINCREF().

Fix coverity report: CID 1417269.

@vstinner
_pickle: Fix whichmodule()
c4e7778 
_PyUnicode_FromId() can return NULL: replace Py_INCREF() with
Py_XINCREF().

Fix coverity report: CID 1417269.
@vstinner vstinner requested a review from tiran September 5, 2017 20:58
tiran
tiran approved these changes Sep 5, 2017
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiran tiran merged commit af46eb8 into python:master Sep 5, 2017
tiran pushed a commit to tiran/cpython that referenced this pull request Sep 5, 2017
@vstinner @tiran
[3.6] _pickle: Fix whichmodule() (pythonGH-3358)
033219e 
_PyUnicode_FromId() can return NULL: replace Py_INCREF() with
Py_XINCREF().

Fix coverity report: CID 1417269.
(cherry picked from commit af46eb8)
@bedevere-bot
Copy link

GH-3361 is a backport of this pull request to the 3.6 branch.

tiran added a commit that referenced this pull request Sep 6, 2017
@tiran
[3.6] _pickle: Fix whichmodule() (GH-3358) (#3361)
c3c3062 
_PyUnicode_FromId() can return NULL: replace Py_INCREF() with
Py_XINCREF().

Fix coverity report: CID 1417269.
(cherry picked from commit af46eb8)
@vstinner vstinner deleted the pickle_coverity branch September 8, 2017 01:13
GadgetSteve pushed a commit to GadgetSteve/cpython that referenced this pull request Sep 10, 2017
@vstinner @GadgetSteve
_pickle: Fix whichmodule() (python#3358)
a6bbb37 
_PyUnicode_FromId() can return NULL: replace Py_INCREF() with
Py_XINCREF().

Fix coverity report: CID 1417269.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @bedevere-bot @tiran @Mariatta @the-knights-who-say-ni