Skip to content

[3.6] _pickle: Fix whichmodule() (GH-3358) #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2017
Merged

[3.6] _pickle: Fix whichmodule() (GH-3358) #3361

merged 1 commit into from
Sep 6, 2017

Conversation

tiran
Copy link
Member

@tiran tiran commented Sep 5, 2017

_PyUnicode_FromId() can return NULL: replace Py_INCREF() with
Py_XINCREF().

Fix coverity report: CID 1417269.
(cherry picked from commit af46eb8)

@vstinner @tiran
[3.6] _pickle: Fix whichmodule() (pythonGH-3358)
033219e 
_PyUnicode_FromId() can return NULL: replace Py_INCREF() with
Py_XINCREF().

Fix coverity report: CID 1417269.
(cherry picked from commit af46eb8)
@bedevere-bot bedevere-bot mentioned this pull request Sep 5, 2017
Merged
vstinner
vstinner approved these changes Sep 5, 2017
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tiran tiran merged commit c3c3062 into python:3.6 Sep 6, 2017
@tiran tiran deleted the backport-af46eb8-3.6 branch September 6, 2017 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiran @vstinner @Mariatta @the-knights-who-say-ni @bedevere-bot