Skip to content

bpo-34120: fix IDLE freezing after closing dialogs #8603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 2, 2018
Merged

bpo-34120: fix IDLE freezing after closing dialogs #8603

merged 3 commits into from
Aug 2, 2018

Conversation

taleinat
Copy link
Contributor

@taleinat taleinat commented Aug 1, 2018 •
edited by terryjreedy
Loading

Added missing .grab_release() calls to all places where we call .grab_set(). This was missing in all cases other than idlelib.searchbase.

https://bugs.python.org/issue34120

@taleinat
bpo-34120: fix IDLE freezing after closing dialogs
8f9c13e 
Removed all calls to .grab_set() and .grab_release(),
which are broken at the Tk level on macOS, and don't
appear to have the desired effect elsewhere.
@taleinat taleinat requested a review from terryjreedy August 1, 2018 08:31
@taleinat taleinat added type-bug An unexpected behavior, bug, or error needs backport to 3.6 DO-NOT-MERGE labels Aug 1, 2018
@taleinat
Copy link
Contributor Author

taleinat commented Aug 1, 2018

Note: The tests failed because of an IDLE test verifying that .grab_set() is called. If we go this route, I'll fix that test.

terryjreedy
terryjreedy approved these changes Aug 1, 2018
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like a no-brainer that grab should be followed by release, except that we got away with just destroy, until we didn't.
I verified that you got added all the missing releases and that there is no apparent change on Windows.
Two of you claiming that this fixes the issue is good enough for me for now. Go ahead and merge and backport to 2.7.

@taleinat taleinat merged commit 10ea940 into python:master Aug 2, 2018
@miss-islington
Copy link
Contributor

Thanks @taleinat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@taleinat taleinat deleted the bpo-34120/fix_about_config_freezing branch August 2, 2018 06:18
@bedevere-bot
Copy link

GH-8613 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 2, 2018
@taleinat @miss-islington
bpo-34120: fix IDLE freezing after closing dialogs (pythonGH-8603)
7f5d490 
Added missing .grab_release() calls to all places where we call .grab_set().
(cherry picked from commit 10ea940)

Co-authored-by: Tal Einat <[email protected]>
taleinat added a commit to taleinat/cpython that referenced this pull request Aug 2, 2018
@taleinat
[2.7] bpo-34120: fix IDLE freezing after closing dialogs (pythonGH-8603)
e166e2b 
Added missing .grab_release() calls to all places where we call .grab_set()..
(cherry picked from commit 10ea940)

Co-authored-by: Tal Einat <[email protected]>
miss-islington added a commit that referenced this pull request Aug 2, 2018
@miss-islington @taleinat
bpo-34120: fix IDLE freezing after closing dialogs (GH-8603)
d9fc795 
Added missing .grab_release() calls to all places where we call .grab_set().
(cherry picked from commit 10ea940)

Co-authored-by: Tal Einat <[email protected]>
@miss-islington
Copy link
Contributor

Thanks @taleinat for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-8615 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 2, 2018
@taleinat @miss-islington
bpo-34120: fix IDLE freezing after closing dialogs (pythonGH-8603)
247b046 
Added missing .grab_release() calls to all places where we call .grab_set().
(cherry picked from commit 10ea940)

Co-authored-by: Tal Einat <[email protected]>
miss-islington added a commit that referenced this pull request Aug 2, 2018
@miss-islington @taleinat
bpo-34120: fix IDLE freezing after closing dialogs (GH-8603)
9fcfb7b 
Added missing .grab_release() calls to all places where we call .grab_set().
(cherry picked from commit 10ea940)

Co-authored-by: Tal Einat <[email protected]>
taleinat added a commit that referenced this pull request Aug 2, 2018
@taleinat
[2.7] bpo-34120: fix IDLE freezing after closing dialogs (GH-8603)
894940b 
Added missing .grab_release() calls to all places where we call .grab_set().

(cherry picked from commit 10ea940)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@taleinat @miss-islington @bedevere-bot @terryjreedy @the-knights-who-say-ni