Skip to content

bpo-34120: fix IDLE freezing after closing dialogs #8603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/idlelib/config_key.py
Original file line number Diff line number Diff line change
Expand Up @@ -235,10 +235,12 @@ def OK(self, event=None):
return
if (self.advanced or self.KeysOK(keys)) and self.bind_ok(keys):
self.result = keys
self.grab_release()
self.destroy()

def Cancel(self, event=None):
self.result=''
self.grab_release()
self.destroy()

def KeysOK(self, keys):
Expand Down
1 change: 1 addition & 0 deletions Lib/idlelib/configdialog.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ def cancel(self):
def destroy(self):
global font_sample_text
font_sample_text = self.fontpage.font_sample.get('1.0', 'end')
self.grab_release()
super().destroy()

def help(self):
Expand Down
1 change: 1 addition & 0 deletions Lib/idlelib/help_about.py
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ def display_file_text(self, title, filename, encoding=None):

def ok(self, event=None):
"Dismiss help_about dialog."
self.grab_release()
self.destroy()


Expand Down
4 changes: 4 additions & 0 deletions Lib/idlelib/query.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,10 @@ def cancel(self, event=None): # Do not replace.
self.result = None
self.destroy()

def destroy(self):
self.grab_release()
super().destroy()


class SectionName(Query):
"Get a name for a config file section name."
Expand Down
1 change: 1 addition & 0 deletions Lib/idlelib/textview.py
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ def __init__(self, parent, title, text, modal=True,

def ok(self, event=None):
"""Dismiss text viewer dialog."""
self.grab_release()
self.destroy()


Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix unresponsiveness after closing certain windows and dialogs.